Metada on session start action #5611

lluchini · 2020-04-09T17:30:05Z

Proposed changes:
Closes #5574

The default action 'action_session_start' wasn't able to receive the metadata from the message sent, RASA when initiating a new session it sends a blank tracker with no information whatsoever, ignoring the metadata into the message.

Adjusted to add the event sessionStart to tracker events and with it the metadata from the message.

Status (please check what you already did):

added some tests for the functionality
updated the documentation
updated the changelog (please check changelog for instructions)
reformat files using black (please check Readme for instructions)

able to receive the metadata from the message sent, RASA when initiating a new session it sends a blank tracker with no information whatsoever, ignoring the metadata into the message. Adjusted to add the event sessionStart to tracker events and with it the metadata from the message.

Method: get_tracker_with_session_start Parameter: metadata

CLAassistant · 2020-04-09T17:30:09Z

All committers have signed the CLA.

lluchini · 2020-04-09T17:43:53Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

lluchini seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Done!

passed black formatter pytype doesn't work on Win10.

sara-tagger · 2020-04-10T06:00:11Z

Thanks for submitting a pull request 🚀 @degiz will take a look at it as soon as possible ✨

degiz

Thanks a lot for the PR 🚀

Left several comments. Looking forward to have this code merged! 👍

tests/core/test_actions.py

rasa/core/processor.py

Co-Authored-By: Alexander Khizov <[email protected]>

#5611

degiz

I didn't get what you meant by more "high level".

The most high level (in terms of structure) code we've modified in this PR is get_tracker_with_session_start(). So I'd expect the unit tests that covers this change to call this method with metadata and assert on the results.

modified get_tracker_with_session_start(). So the unit tests that covers this change to call this method with metadata and assert on the results.

lluchini · 2020-04-17T11:55:00Z

I didn't get what you meant by more "high level".

The most high level (in terms of structure) code we've modified in this PR is get_tracker_with_session_start(). So I'd expect the unit tests that cover this change to call this method with metadata and assert the results.

I hope that I had understand what you meant, I added a test into test_processor.py to this specific method and assertion of the metadata content.

wasn't me but, I fixed anyway.

it's a false positive.

lluchini · 2020-04-17T12:45:01Z

The deep source is failing with a false positive.

lluchini · 2020-04-17T12:50:39Z

Faling Not My Fault :)

Continuous Integration / Build Docker (docker/Dockerfile_pretrained_embeddings_spacy_en, -spacy-en) (pull_request) Failing after 7m — Build Docker (docker/Dockerfile_pretrained_embeddings_spacy_en, -spacy-en)

Motive

Error processing tar file(exit status 1): write /root/.cache/pip/http/d/9/c/c/b/d9ccb85290d9889b7fd067a45d9cd98ce7bcd4ee2d66f167f5e940c2: no space left on device

degiz

Awesome test, thanks!

Last comment, and we can merge it.

changelog/5574.bugfix.rst

tests/core/test_actions.py

tests/core/test_processor.py

Co-Authored-By: Alexander Khizov <[email protected]>

(https://github.com/degiz) https://github.com/RasaHQ/rasa/pull/5611/files/afc0263ff656f5fb00e078a390f77520640ff178

lluchini · 2020-04-17T19:40:09Z

DeepSource is a false positive;
Continuous Integration / Build Docker is a problem of space; and
Continuous Integration / Run Tests can't know, it doesn't say what's wrong and I'm not able to run tests on Windows (apparently Sanic doesn't like windows very much, I'm working on it...).

degiz

Great job! 👍
I'm approving the PR, let's make sure the unit tests are passing in the CI.

lluchini · 2020-04-21T10:28:26Z

@degiz

Great job! 👍
I'm approving the PR, let's make sure the unit tests are passing in the CI.

Thanks, you made my first contribution to an open-source project so smooth, I really appreciate!

So is that it? do I have to do something more?

degiz · 2020-04-21T10:33:21Z

@lluchini welcome to the club 🚀

Now we're basically trying to merge the PR before the master goes ahead 😄

lluchini added 2 commits April 9, 2020 12:03

Updating doc string for:

b53cdb1

Method: get_tracker_with_session_start Parameter: metadata

lluchini changed the title ~~Metada on session start action~~ Metada on session start action Closes #5574 Apr 9, 2020

lluchini and others added 3 commits April 9, 2020 15:06

PEP8 - line too long adjust.

09260e3

Merge branch 'master' into metada-on-session-start-action

91834f9

Appended test to improved functionality

376e90f

passed black formatter pytype doesn't work on Win10.

lluchini changed the title ~~Metada on session start action Closes #5574~~ Metada on session start action Apr 9, 2020

sara-tagger requested a review from degiz April 10, 2020 06:00

Adding changelog.

e4b3e6a

degiz added this to the Rasa 1.10 milestone Apr 16, 2020

degiz added the priority:normal label Apr 16, 2020

Merge branch 'master' into metada-on-session-start-action

2b79796

degiz suggested changes Apr 16, 2020

View reviewed changes

tests/core/test_actions.py Outdated Show resolved Hide resolved

rasa/core/processor.py Outdated Show resolved Hide resolved

lluchini and others added 3 commits April 16, 2020 16:36

Update tests/core/test_actions.py

c41c084

Co-Authored-By: Alexander Khizov <[email protected]>

Adjust suggested by degiz (https://github.com/degiz)

0bd3d3b

#5611

Merge branch 'master' into metada-on-session-start-action

e56e176

lluchini requested a review from degiz April 16, 2020 20:24

degiz suggested changes Apr 17, 2020

View reviewed changes

Most high level (in terms of structure) code we've

f9bb458

modified get_tracker_with_session_start(). So the unit tests that covers this change to call this method with metadata and assert on the results.

lluchini and others added 4 commits April 17, 2020 08:56

Merge branch 'master' into metada-on-session-start-action

ef00657

DeepSource identified a patern break,

d633cf6

wasn't me but, I fixed anyway.

DeepSource identified a patern break,

2a3e2de

wasn't me but, I fixed anyway.

The deep source is faling without reason,

afc0263

it's a false positive.

degiz self-requested a review April 17, 2020 13:07

degiz suggested changes Apr 17, 2020

View reviewed changes

changelog/5574.bugfix.rst Outdated Show resolved Hide resolved

tests/core/test_actions.py Outdated Show resolved Hide resolved

tests/core/test_processor.py Outdated Show resolved Hide resolved

lluchini and others added 3 commits April 17, 2020 13:33

Update changelog/5574.bugfix.rst

26b1cad

Co-Authored-By: Alexander Khizov <[email protected]>

Update tests/core/test_processor.py

4f9f05b

Co-Authored-By: Alexander Khizov <[email protected]>

Removed by sugestion of degiz

2dadeb6

(https://github.com/degiz) https://github.com/RasaHQ/rasa/pull/5611/files/afc0263ff656f5fb00e078a390f77520640ff178

lluchini requested a review from degiz April 17, 2020 19:19

degiz approved these changes Apr 21, 2020

View reviewed changes

Merge branch 'master' into metada-on-session-start-action

c7e7d7f

degiz added 4 commits April 22, 2020 11:08

Merge branch 'master' into metada-on-session-start-action

5735c93

Merge branch 'master' into metada-on-session-start-action

4243dfd

Merge branch 'master' into metada-on-session-start-action

ac060c9

Merge branch 'master' into metada-on-session-start-action

b759106

degiz merged commit 002b892 into RasaHQ:master Apr 22, 2020

lluchini mentioned this pull request May 1, 2020

Restarting Session on Every Message #5767

Merged

1 task

degiz mentioned this pull request Jun 5, 2020

Cutom metadata restarts the session #5964

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Metada on session start action #5611

Metada on session start action #5611

lluchini commented Apr 9, 2020 •

edited

Loading

CLAassistant commented Apr 9, 2020 •

edited

Loading

lluchini commented Apr 9, 2020

sara-tagger commented Apr 10, 2020

degiz left a comment

degiz left a comment

lluchini commented Apr 17, 2020 •

edited

Loading

lluchini commented Apr 17, 2020

lluchini commented Apr 17, 2020

degiz left a comment

lluchini commented Apr 17, 2020

degiz left a comment

lluchini commented Apr 21, 2020 •

edited

Loading

degiz commented Apr 21, 2020

Metada on session start action #5611

Metada on session start action #5611

Conversation

lluchini commented Apr 9, 2020 • edited Loading

CLAassistant commented Apr 9, 2020 • edited Loading

lluchini commented Apr 9, 2020

sara-tagger commented Apr 10, 2020

degiz left a comment

Choose a reason for hiding this comment

degiz left a comment

Choose a reason for hiding this comment

lluchini commented Apr 17, 2020 • edited Loading

lluchini commented Apr 17, 2020

lluchini commented Apr 17, 2020

degiz left a comment

Choose a reason for hiding this comment

lluchini commented Apr 17, 2020

degiz left a comment

Choose a reason for hiding this comment

lluchini commented Apr 21, 2020 • edited Loading

degiz commented Apr 21, 2020

lluchini commented Apr 9, 2020 •

edited

Loading

CLAassistant commented Apr 9, 2020 •

edited

Loading

lluchini commented Apr 17, 2020 •

edited

Loading

lluchini commented Apr 21, 2020 •

edited

Loading