Utter actions #5297

MichaelMarien · 2020-02-22T12:15:09Z

Proposed changes:

Fixes Update documentation regarding utterance actions #5174
Updated documentation to no longer explicitly ask users to mention utterance actions under the action part of the domain but only under responses
Updated all examples also
Updated all tests to make sure we test domain files with the new settings (no explicit listing of utterance actions). Note that this changes some older tests, a few tests that focus on the working of the deprecated functionality are kept. We can duplicate all domain tests to work with and without explicate mentioning of the utterance actions, but not sure if this is worth the effort. Put this as a potential todo depending on input.

Status (please check what you already did):

added some tests for the functionality
updated the documentation
updated the changelog (please check changelog for instructions)
reformat files using black (please check Readme for instructions)
re-added all domain tests with deprecated utterance action behaviour

…erance actions in explanation

…erance actions in explanation of faq

…ting

…esting

claassistantio · 2020-02-22T12:15:34Z

All committers have signed the CLA.

sara-tagger · 2020-02-24T07:00:10Z

Thanks for submitting a pull request 🚀 The assigned reviewer will take a look at it as soon as possible✨

tmbo

I think this is a good step forward - thanks a lot for jumping on this 🚀

I think before we can merge this, it would be great to add at least one test checking that the behaviour is the same between:

creating a domain with utter_ actions listed in actions section
creating a domain without any actios in there

Just to make sure we still properly parse that part until we remove the deprecated utter_ actions completely

changelog/5174.doc.rst

Co-Authored-By: Tom Bocklisch <[email protected]>

…tterance actions

MichaelMarien · 2020-02-25T19:08:30Z

Thanks for the comments!

I think before we can merge this, it would be great to add at least one test checking that the behaviour is the same between:

creating a domain with utter_ actions listed in actions section

creating a domain without any actios in there

Just to make sure we still properly parse that part until we remove the deprecated utter_ actions completely

Added a test.

tmbo

looks good, thanks a lot for digging into this 🚀

@tabergma

* refactor loss and f1 helpers * review comments on featurizers * fix docstrings in components * review comments on lexical_syntactic_featuirzer. * review comments on convert * Update 5292.enhancement.rst * review comments on hugging face components * rename inverted tag and label dicts * remove _find_example_for_tag * remove setting numpy random seed in train * review comments * create no entity tag constant * add type to tf_layers * update constants comment * remove magic numbers probs * fix type of Data in model data * add axis= * add explanatory comments * add RabbitMQ message header to "rasa export" * fix isinstance() calls * check if responses are present. * fix test * review comments * Apply suggestions from code review * update docstring * update method * add comment and type * rename relative lengths * remove batch_tuple_sizes * review comments * review comments * add docstring * add comments to model data * create tmp dir for convert * update type * add comments * change comment * recalculate number of examples after balancing * reorganize methods in model_data * remove num_neg check from ted * update requirements * fix nlu comparison test * update requirements * removed whitespace * update version * Update alt_requirements/requirements_pretrained_embeddings_convert.txt Co-Authored-By: Tobias Wochinger <[email protected]> * Fixed an issue with AWS persistor - It's possible now to specify region name for AWS S3 - Tests are setting mock region name now * Poetry for Rasa * Missing lockfile * Updated Dockerfile: rasa-sdk added * Travisfile and Dockerfile updates * Updated alt_requirements * Docs fixes * Updates for dependencies + github workflow * Update for documentation.yml * Updated dependencies * CI updates * Updated lockfile * CI update * Updated lockfile * Updates! * Dependencies fix * Updates for release.py and pika dependency * Fixes and updates * Updated dockerfiles * Dockerfiles updates and fixes * Utter actions (RasaHQ#5297) removed utterance actions from examples and documentation * Post-rebase fixes — updated dockerfiles and pyproject.toml * Updated dockerfiles * Updated dockerfiles * Returning back tensorflow_text * Typo fix * maybe make test_evaluation stable * make sure to commit pyproject toml as part of release script * Poetry integration fix: making kafka non-optional * fixed missing kafka dependency * made poetry version script executable * added poetry version to pyproject * [Rasa Open Source 1.8.0 Release] - Updated version of SDK * [Rasa Open Source 1.8.0 Release] - Updated release script - script now uses pyproject.toml to get version of sdk * prepared release of version 1.8.0 * updated dependencies * improved caching * updated the slack client * properly split text messages for socket io channel * mark test_end_to_end_evaluation_script as flaky * do cache rasabaster template * fixed docker builds by excluding configs from docker ignore * marked pretrained model test as flaky * added github token to slack publishing * Fixed dockerifles for 1.8.0 release * Make sure we install rasa in non-editable mode in Dockerfiles * Better way of building in non-editable mode with poetry * Returning pip<20 back * don't rely on restaurantbot * remove incorrect changelog entry * don't train nlu of formbot * update test story * remove deprecation warnings * add comment to story * beginnings of splitting up docker info, needs cleanup * clean up tracker store docs code formatting * fixes bug * fix failing test * added a test for bug as well * add check for failing test again * add changelog * build containers in gh * fix logging statement * update event broker docs * update oov warning * review comment * Apply suggestions from code review Co-Authored-By: ricwo <[email protected]> * remove optional kafka install instructions * prepared release of version 1.8.1 * fixed tagging * fixed tagging * update wording * add details * updated dep * fix ujson as well * update based on copy suggestions * update code examples * made ujson flexible * docstrings to utils.hugging_face * fix typo * explain token id * add an example for unexpected user input; consitently call domain domain.yml * add an example for unexpected user input; consitently call domain domain.yml * some more examples * links to sections * updates for 1.8; checklists for tutorials; split up tutorials * merge back to one tutorial * move checklists to end * switch to newer 'async' syntax * clarify no-root user usage with sdk image * add changelog entry * fix override config * Update docs/user-guide/building-assistants.rst Co-Authored-By: Akela Drissner-Schmid <[email protected]> * Update docs/user-guide/building-assistants.rst Co-Authored-By: Akela Drissner-Schmid <[email protected]> * Update docs/user-guide/building-assistants.rst Co-Authored-By: Akela Drissner-Schmid <[email protected]> * Update docs/index.rst Co-Authored-By: Akela Drissner-Schmid <[email protected]> * rebase pr updates * set weight sparsity to 0 in embed intent classifier * update migration guide * Update docs/user-guide/building-assistants.rst Co-Authored-By: Akela Drissner-Schmid <[email protected]> * Update docs/user-guide/building-assistants.rst Co-Authored-By: Akela Drissner-Schmid <[email protected]> * change wording in checklists * review comments * fixed a few typos * simplify checklist * checklist updates * Apply suggestions from code review Co-Authored-By: Akela Drissner-Schmid <[email protected]> * implement some of my changes * rasa open source * review comments, improve links * suggest one-line deployment * edits to deploy in docker-compose page * small improvements to docs * no more docker compose * fix errors * pin tensorflow-estimator to 2.1.0 * add changelog entry * explain dependency pin in pyproject.toml * add class name of calling class to log message to avoid confusion in case this is executed from a subclass * add class name of calling class to log message to avoid confusion in case this is executed from a subclass * changelog for pr RasaHQ#5444 * prepared release of version 1.8.2 * update changelog with missing entries * fix some review comments * sort nlu/story files before training * more review comments * fix tracker store configuration docs * fix types * fix data tests * clarify choosing a tag * clarify actions folder for image building * use release insetad of latest in deploy in docker * use release and version instead of latest in build in docker * version every docker command and restructure a bit * fix build warnings * Update docs/user-guide/docker/building-in-docker.rst Co-Authored-By: Akela Drissner-Schmid <[email protected]> * use -full tag * clarify how to direct endpoints to service, add a custom tracker store, and fix oracle documentation versioning * fix reference in changelog * fix changelog ... again * suggested changes by @tabergma on RasaHQ#5444 * set default value for weight_sparsity in response selector to 0 * prepared release of version 1.8.3 * more verbose changelog * Updated poetry.lock and dependencies Co-authored-by: Vova Vv <[email protected]> Co-authored-by: Tanja Bergmann <[email protected]> Co-authored-by: Melinda Loubser <[email protected]> Co-authored-by: Tom Bocklisch <[email protected]> Co-authored-by: ricwo <[email protected]> Co-authored-by: Vladimir Vlasov <[email protected]> Co-authored-by: Tobias Wochinger <[email protected]> Co-authored-by: Alexander Khizov <[email protected]> Co-authored-by: alwx <[email protected]> Co-authored-by: MichaelMarien <[email protected]> Co-authored-by: Will Kearns <[email protected]> Co-authored-by: Alexander Khizov <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Daksh <[email protected]> Co-authored-by: melindaloubser1 <[email protected]> Co-authored-by: Akela Drissner-Schmid <[email protected]> Co-authored-by: akelad <[email protected]> Co-authored-by: m-vdb <[email protected]> Co-authored-by: thomas <[email protected]> Co-authored-by: Maxime Vdb <[email protected]> Co-authored-by: Thomas <[email protected]>

MichaelMarien added 28 commits February 22, 2020 11:26

removed utterance actions from moodbot example

b192c48

removed utterance actions from initial_project

2e02b0c

updated default_with_slots yaml for domain tests

001dfdc

updated documentation building-assistants and removed presence of utt…

9d5d72c

…erance actions in explanation

updated documentation building-assistants and removed presence of utt…

6395a23

…erance actions in explanation

updated documentation building-assistants and removed presence of utt…

354e40b

…erance actions in explanation

updated documentation building-assistants and removed presence of utt…

e5725a5

…erance actions in explanation

updated documentation building-assistants and removed presence of utt…

f6a1b9d

…erance actions in explanation of faq

removed utterance actions in duplicate entities test for domain

0d9e2cb

changed example of rasa yml

2a1baaf

removed utter actions from test multi-domain rasa

4041a4e

removed utterance actions from default yml in domain tests

bca068e

removed utterance actions from default with mapping yml in domain tests

52d8c20

removed utterance actions from missing text yml in domain tests

f2769fe

removed utterance actions from form yml for domain testing

5046259

removed utterance actions from duplicate templates yml for domain tes…

da96228

…ting

removed utterance actions from duplicate intents yml for domain testing

5ec47d5

removed utterance actions from unfeaturized entities yml for domain t…

c02e1e5

…esting

changed greetbot domain in multi domain tests

16d613e

changed moodbot domain in multi domain tests

8b8e86d

remove utterance action

0da021c

remove utterance action from custom slot type test

91a98c5

remove utterance action from fail on unknown custom slot type test

1f97261

remove utterance action from default domain test

0f9340c

remove utterance action from fail on unknown custom slot test

8ea18de

remove utterance action from domain to yaml test

65f845d

remove utterance action from merge domains test

0193164

changelog

35a5228

added respoinse to test merge yaml domains

3592fcc

MichaelMarien added 5 commits February 22, 2020 15:03

removed blank line

16777bf

added a template for utter_ask_continue

ad2a5f0

added a template in domain in merge domain test

8c506ad

added a template in domain in merge domain test

fd05aa1

reformat

9bc6b14

sara-tagger requested a review from erohmensing February 24, 2020 07:00

tmbo reviewed Feb 25, 2020

View reviewed changes

changelog/5174.doc.rst Outdated Show resolved Hide resolved

MichaelMarien and others added 5 commits February 25, 2020 16:42

Update changelog/5174.doc.rst

195ab4e

Co-Authored-By: Tom Bocklisch <[email protected]>

Merge branch 'upstream-master' into utter-actions

638e191

added test to check domain loading from yaml that contains explicit u…

6397726

…tterance actions

fixed test to check domain loading from yaml that contains explicit u…

d3289e9

…tterance actions

Merge remote-tracking branch 'origin/utter-actions' into utter-actions

d204e1e

erohmensing removed their request for review February 26, 2020 10:15

tmbo approved these changes Feb 26, 2020

View reviewed changes

Merge branch 'master' into utter-actions

b2d8295

tmbo merged commit 2edc18a into RasaHQ:master Feb 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Utter actions #5297

Utter actions #5297

MichaelMarien commented Feb 22, 2020 •

edited

Loading

claassistantio commented Feb 22, 2020 •

edited

Loading

sara-tagger commented Feb 24, 2020

tmbo left a comment

MichaelMarien commented Feb 25, 2020

tmbo left a comment

Utter actions #5297

Utter actions #5297

Conversation

MichaelMarien commented Feb 22, 2020 • edited Loading

claassistantio commented Feb 22, 2020 • edited Loading

sara-tagger commented Feb 24, 2020

tmbo left a comment

Choose a reason for hiding this comment

MichaelMarien commented Feb 25, 2020

tmbo left a comment

Choose a reason for hiding this comment

MichaelMarien commented Feb 22, 2020 •

edited

Loading

claassistantio commented Feb 22, 2020 •

edited

Loading