for "rasa test core --evaluate-model-directory" set default for "--model" to directory #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e as --model, use the folder that file is in as --model instead
|
|
wochinge
reviewed
Jan 23, 2020
There was a problem hiding this comment.
Congrats to your first PR 🎉
Regarding the side-effect which you mentioned (thanks for pointing this ambiguous behavior out!):
how about checking the passed model is != model.get_latest_model(directory) (the function is in the module rasa.model) and then print a warning. In case the passed model name is == model.get_latest_model(directory) we can assume it's the default model and wasn't explicitly passed in by the user.
added 6 commits
January 23, 2020 17:07
….path; add return types
wochinge
reviewed
Jan 28, 2020
Co-Authored-By: Tobias Wochinger <[email protected]>
wochinge
approved these changes
Jan 28, 2020
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
If rasa test core is called with --evaluate-model-directory and a file as --model, use the folder that file is in as --model instead.
This fixes #4896 : When no --model argument is given, instead of defaulting to the latest model in ./models it now defaults to ./models
Side effect: When called with "--model some_folder/some_file.tar.gz", it uses some_folder as --model instead. Is this something we want? If yes, should the code throw a warning like "you provided a file as --model, will use the folder that file is in instead"?
Status (please check what you already did):
black(please check Readme for instructions)