-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5040 fixed networkx requirement #5071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot for investigating this issue ⭐
Do you mind taking a look at the suggestions regarding the changelog entry? This is meant for end-users, so I'd remove some of the details.
Better end-user text Co-Authored-By: Tom Bocklisch <[email protected]>
More informative text. Co-Authored-By: Tom Bocklisch <[email protected]>
Done. Suggestions accepted @tmbo. All checks passing. LGTM? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks a lot for the investigation 🕵 ⭐️
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)