Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5040 fixed networkx requirement #5071

Merged
merged 5 commits into from
Jan 16, 2020
Merged

#5040 fixed networkx requirement #5071

merged 5 commits into from
Jan 16, 2020

Conversation

staticdev
Copy link

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot for investigating this issue ⭐
Do you mind taking a look at the suggestions regarding the changelog entry? This is meant for end-users, so I'd remove some of the details.

changelog/5040.bugfix.rst Outdated Show resolved Hide resolved
changelog/5040.bugfix.rst Show resolved Hide resolved
changelog/5040.bugfix.rst Outdated Show resolved Hide resolved
Thiago C. D'Ávila and others added 3 commits January 15, 2020 15:31
Better end-user text

Co-Authored-By: Tom Bocklisch <[email protected]>
More informative text.

Co-Authored-By: Tom Bocklisch <[email protected]>
@staticdev
Copy link
Author

Looks good, thanks a lot for investigating this issue
Do you mind taking a look at the suggestions regarding the changelog entry? This is meant for end-users, so I'd remove some of the details.

Done. Suggestions accepted @tmbo. All checks passing. LGTM?

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks a lot for the investigation 🕵 ⭐️

@tmbo tmbo merged commit dfb803b into RasaHQ:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent requirements in Rasa 1.6.0
2 participants