Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it clear what policy failed because of bad kwarg #4936

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Dec 10, 2019

Proposed changes:

  File "/Users/ella/rasa/rasa/core/policies/ensemble.py", line 322, in from_dict
    raise Exception(f"Could not initialize {policy_name}. {e}")
Exception: Could not initialize FormPolicy. __init__() got an unexpected keyword argument 'nlu_threshold'

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@erohmensing erohmensing requested review from imLew and btotharye and removed request for imLew December 10, 2019 15:53
@btotharye
Copy link
Contributor

@erohmensing just want to make sure I"m not missing it but I don't see any tests added? I only ask because that checkbox is selected. Just wanted to make sure I wasn't missing anything, other than that the message looks good to me.

@erohmensing
Copy link
Contributor Author

Oh whoops, I didn't mean to add a test -- thought about it but it's just improving the wording of an exception that is already raised, so would be pretty expensive to check just for that. i've removed the checkbox

@erohmensing erohmensing merged commit 0de37d6 into 1.5.x Dec 10, 2019
@erohmensing erohmensing deleted the policy-warn branch February 4, 2020 20:00
@abedin-keshavarz234
Copy link

hi i have error (help me)
TypeError: init() got an unexpected keyword argument 'drug_similarity'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants