Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change url to host in custom tracker store #4808

Merged
merged 15 commits into from
Dec 4, 2019
Merged

change url to host in custom tracker store #4808

merged 15 commits into from
Dec 4, 2019

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Nov 20, 2019 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@erohmensing
Copy link
Contributor Author

erohmensing commented Nov 20, 2019 •
edited
Loading

@akelad I almost think it makes more sense to change host to url as the __init__ params in every tracker store. All of the other parameters match how they are pulled from endpoints.yml exactly, that seems more intuitive, and wouldn't require people to update their existing custom tracker stores

@erohmensing erohmensing requested a review from akelad November 20, 2019 17:38
@erohmensing erohmensing requested a review from wochinge November 26, 2019 16:10
wochinge
wochinge approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is great 👍 Can we make this non-breaking? Otherwise I'd might even add it to the migration guide

rasa/core/tracker_store.py Outdated Show resolved Hide resolved
@akelad akelad removed their request for review November 27, 2019 09:15
tmbo
tmbo previously requested changes Nov 28, 2019
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@erohmensing
Copy link
Contributor Author

@wochinge would you take another look at the deprecation?

wochinge
wochinge approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

rasa/core/tracker_store.py Outdated Show resolved Hide resolved
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
tests/core/test_tracker_stores.py Outdated Show resolved Hide resolved
data/test_endpoints/custom_tracker_test_endpoints.yml Outdated Show resolved Hide resolved
@erohmensing erohmensing requested a review from tmbo November 29, 2019 19:33
@erohmensing
Copy link
Contributor Author

Won't let me merge til @tmbo approves 😄

@erohmensing
Update test_tracker_stores.py
02d8a27 
Check there are no warnings in host argument test
tmbo
tmbo reviewed Dec 4, 2019
View reviewed changes
changelog/4734.improvement.rst Outdated Show resolved Hide resolved
@erohmensing erohmensing merged commit 4660adf into master Dec 4, 2019
@erohmensing erohmensing deleted the host-url branch February 4, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo left review comments

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename url parameter to host for custom tracker store
3 participants
@erohmensing @tmbo @wochinge