Improve Slack Sanitization #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update 9/9
Latest code merge
|
@erohmensing not able to get much out of this build error log "Makefile:40: recipe for target 'lint' failed Can you please help me :)? |
|
@vigneshp826 You have to reformat your files using black (https://github.com/rasahq/rasa#code-style). |
|
But thank you for your PR, we'll give it a review as soon as possible. |
msamogh
suggested changes
Sep 18, 2019
|
A changelog entry would be good too please :) |
|
changelog entry under [Unreleased 1.4.0] - master ? |
|
@vigneshp826 Yes |
|
added changelog entry |
msamogh
approved these changes
Sep 18, 2019
rasa/core/channels/slack.py
Outdated
| replacement = regex.split("|")[1] | ||
| replacement = replacement.replace('>', '') | ||
| text = text.replace(regex, replacement) | ||
| else: |
There was a problem hiding this comment.
The else part can be dropped.
|
But it looks good otherwise. Thanks for your contribution! |
msamogh
suggested changes
Sep 18, 2019
msamogh
approved these changes
Sep 18, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
text generated by slack and substitute it with original content
Status (please check what you already did):
black(please check Readme for instructions)