Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore documentation building parameters compatible with node 12 #11566

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

znat
Copy link
Contributor

@znat znat commented Sep 12, 2022

This PR reverts commit b775964.

Proposed changes:

  • Currently the documention website requires node.js <= 12.22.x, this PR reverts an accidental change

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@znat znat marked this pull request as ready for review September 12, 2022 13:33
@znat znat requested a review from a team as a code owner September 12, 2022 13:33
@znat znat requested review from aerowithanl and removed request for a team September 12, 2022 13:33
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11566--rasahq-docs-rasa-v2.netlify.app/docs/rasa

Copy link

@aerowithanl aerowithanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@znat znat merged commit bd88fda into main Sep 12, 2022
@znat znat deleted the restore-documentation-node-version branch September 12, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants