Dynamic Form Docs Section Update #10734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
indam23
suggested changes
Jan 25, 2022
docs/docs/forms.mdx
Outdated
| @@ -388,6 +388,35 @@ class ValidateRestaurantForm(FormValidationAction): | |||
| return additional_slots + domain_slots | |||
| ``` | |||
|
|
|||
| If conversely, you'd prefer to remove a slot from the form's `required_slots` defined in the domain file in certain conditions, | |||
| we recommend to copy the `domain_slots` over to a new variable and applying changes to that new variable instead of modifying directly | |||
There was a problem hiding this comment.
Suggested change
| we recommend to copy the `domain_slots` over to a new variable and applying changes to that new variable instead of modifying directly | |
| you can copy the `domain_slots` over to a new variable and apply changes to that new variable instead of directly modifying |
There was a problem hiding this comment.
will anything bad happen if they do modify it directly or is it just for clarity?
There was a problem hiding this comment.
They won't get the behaviour they want (not requesting the removed slot), because Rasa will instead use the list of required slots defined in the domain, I explained how this occurs in the comment here.
There was a problem hiding this comment.
Ah I see thanks!
In that case we should be stronger in the wording e.g.
you should copy the `domain_slots` over to a new variable and apply changes to that new variable instead of directly modifying `domain_slots`. Directly modifying `domain_slots` can cause unexpected behaviour.
indam23
approved these changes
Jan 25, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)