-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for different recipes #10641
Merged
Merged
Changes from 10 commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
78fc387
Add support for different recipes
661342c
Remove extra import
4554cc2
Fix changes so tests pass and backwards compatible
561b282
Merge branch 'main' into tayfun/10473-support-other-recipes
890812b
Graph recipe beginnings
e883752
Fix code climate
08da835
Fix auto_configure test failures
f78b775
Fix mypy errors
4b8d17a
Fix tests
4d1288a
Fix flake8 warnings
3f8f471
What happens in shared stays in shared
d967bc2
Merge branch 'main' into tayfun/10473-support-other-recipes
9332d63
Fix tests
495fc49
Fix mypy complaints
3306db5
Fix tests
a057cdc
Fix tests
fc19f83
Fix extra import
df2098e
No need to change auto-config template
c44ea8c
Merge branch 'main' into tayfun/10473-support-other-recipes
248d0ea
Mark as experimental and track recipe via telemetry
1b25fa3
Warn if CLI parameters for graph recipe
1ddc9be
Fix graph recipe
bcb659c
Merge branch 'main' into tayfun/10473-support-other-recipes
ef42783
Fix tests
3716a7d
Black reformat
a1fa40a
Update with new component
ae9f5e5
Fix registered component doc example
49ce5d6
Add docs for graph recipe
2293bca
Merge branch 'main' into tayfun/10473-support-other-recipes
ea70d41
Fix recipe docs URL in warning
47683f7
Fix example code path
2ef1118
Fix docs
8e2568a
Add changelog
f20c898
Fix docs
3e93547
Fix docs broken link
154056f
Merge branch 'main' into tayfun/10473-support-other-recipes
875a17d
Update docs/docs/graph-recipe.mdx
22e6e2c
Bump google-github-actions/setup-gcloud from 0.3.0 to 0.4.0
dependabot[bot] b6b3427
update endpoint and unit tests
ancalita dec37e0
add changelog
ancalita 5ac4b08
add request timeout to cli command line arguments
donodje d4c8836
parse request timeout from command line args and set DEFAULT_REQUEST_…
donodje f44e014
test that the default request timeout argument is used properly
donodje ef6ce21
fix linter errors
donodje 1f67c2f
directly access sys.argv to read the cmd line parameters
donodje b5fde26
remove trailing whitespace
donodje 5330be7
run black to fix linter issues
donodje f79c756
deduplicate declaration of DEFAULT_RESPONSE_TIMEOUT and DEFAULT_REQUE…
donodje 83ae794
correct constants import path in test
donodje 3c15a3a
lint against upgraded black version 21.7b0
donodje 74ab4b2
add changelog entry
donodje ad49502
set the request timeout from the request timeout command line arg
donodje 094b49b
move DEFAULT_STREAM_READING_TIMEOUT to rasa.core.constants
donodje 1f53e10
set default param for _get_stream_reading_timeout
donodje de72159
set None default for request_timeout parameter
donodje fc66008
Remove default schemas which is same for recipes
7368dd1
Merge branch 'main' into tayfun/10473-support-other-recipes
8304754
Update rasa/engine/recipes/default_recipe.py
f8ec9da
Make core|nlu_target to be configurable
1b9954a
Make tests clear; rewrite without monkeypatch
cb454dd
Fix typo
fa43bac
Add tip at the top for graph recipe docs
249a046
fix over-indent in Tokenizers section of docs (#10555)
Polaris000 1d3dc70
Merge branch 'main' into tayfun/10473-support-other-recipes
8e631e3
Fix mypy error
495fb46
Fix tests for auto-config
e5fa3ca
Update docs with target nodes
2b5af0f
Merge branch 'main' into tayfun/10473-support-other-recipes
fb9479b
Update docs/docs/graph-recipe.mdx
2bc6fe5
Move graph recipe to data folder for tests
9c771c8
Warn if multiple importers are used
b43566f
Add graph config schemas to telemetry
998da42
Fix changelog URL
3a491d4
Merge branch 'main' into tayfun/10473-support-other-recipes
16a4c24
Revert "Fix changelog URL"
fa1c2eb
Fix link to yet inexistent graph recipe docs
5efdb50
Add test for graph recipe telemetry event
b978569
Make targets required, raise if not provided
506f130
Fix mypy
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
from rasa.engine.recipes.recipe import Recipe | ||
from rasa.engine.graph import GraphModelConfiguration | ||
from rasa.shared.data import TrainingType | ||
|
||
from typing import Dict, Text, Any | ||
|
||
|
||
class GraphV1Recipe(Recipe): | ||
"""Recipe which converts the graph model config to train and predict graph.""" | ||
|
||
name = "graph.v1" | ||
|
||
def graph_config_for_recipe( | ||
self, | ||
config: Dict, | ||
cli_parameters: Dict[Text, Any], | ||
training_type: TrainingType = TrainingType.BOTH, | ||
joejuzl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
is_finetuning: bool = False, | ||
) -> GraphModelConfiguration: | ||
"""Converts the default config to graphs (see interface for full docstring).""" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something more explicit about filling in gaps in a configuration file?