updated poetry to 1.1.4 #363
Conversation
|
This appears to be breaking when installing the dependencies for the tests... |
|
this seems to be an issue with an old pip version being used, I've added a separate build step to update pip and seems to be working now: python-poetry/poetry#3329 (comment) also increased dependency ranges (updates from depandabot) since I needed to regenerate the lockfile anyways |
|
already everything working now - ready for another review @joejuzl |
| @@ -46,6 +46,9 @@ jobs: | |||
| key: ${{ runner.os }}-poetry-3.7-${{ hashFiles('**/poetry.lock') }} | |||
| restore-keys: ${{ runner.os }}-poetry- | |||
|
|
|||
| - name: Update Buildtools 🥄 | |||
There was a problem hiding this comment.
I wonder if we want these in the other project repos too?
|
🛑 can't be merged yet, build system requires the poetry version which isn't mentioned anywhere after switching the builder...python-poetry/poetry#3469 |
|
Can we please wrap this up? Will release 2.3 with the old version. |
|
Well, we need to solve the problem of the missing poetry version. we need to find a good spot to store that, until poetry hopefully comes up with their way of handling this. not sure if we can just add a random property to e.g. the pyproject file |
|
Why aren't we running in the same issues on Rasa Open Source / Rasa X? |
|
taking a look at the code it seems like Joe fixed it for Rasa Open Source by writing the poetry version into a separate file. https://github.com/RasaHQ/rasa/pull/7502/files so that code should just be ported to the sdk |
|
I will port the changes. |
|
you'r the best 🚀 thanks a lot |
pyproject.toml
Outdated
| coveralls = "^2.1.2" | ||
| pytest = "^5.4.1" | ||
| coveralls = "^2.2.0" | ||
| pytest = "^6.1.2" |
There was a problem hiding this comment.
that's also different from Rasa Open Source which is fine, but I think for ease of development it would be great if these are similar
Proposed changes:
Status (please check what you already did):