fix: check and convert keypair to buffer #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangerMauve
requested changes
Jun 27, 2020
index.js
Outdated
| @@ -29,6 +29,20 @@ class P2Plex extends EventEmitter { | |||
| if (listenSelf) this.swarm.join(this.publicKey, { announce: true, lookup: false }) | |||
| } | |||
|
|
|||
| get keyPair () { | |||
| let { publicKey, secretKey } = this.opts.keyPair || noisePeer.keygen() | |||
There was a problem hiding this comment.
I think it'd be good to move this initialization into the constructor, otherwise we could be calling noisePeer.keygen() ever time this.keypair is invoked (every time this.publicKey is invoked too)
There was a problem hiding this comment.
@RangerMauve ah good call. Adjusted!
RangerMauve
approved these changes
Jun 27, 2020
|
Thank you for the fix! Hope it helps make stuff work on the web. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes I made to get p2plex working in a next.js application (with these aliases via webpack). I have not tested to confirm that these changes work in a node.js env yet, but wanted to get this PR open! Related: #2
I also bumped some dependencies