Add flag to add concrete setters for optionals #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mads-b, for completeness, please add a test Record that has |
|
@mads-b Looks good - please rebase with master |
Randgalt
reviewed
Mar 21, 2022
|
|
||
| static Optional<OptionalType> fromClassType(final ClassType component) { | ||
| if (isOptional(component)) { | ||
| if (!(component.typeName() instanceof ParameterizedTypeName)) { |
There was a problem hiding this comment.
Can be:
if (!(component.typeName() instanceof ParameterizedTypeName parameterizedType))
mads-b
force-pushed
the
feature/concreteoptional
branch
from
0820224 to
50beec3
Compare
mads-b
force-pushed
the
feature/concreteoptional
branch
from
50beec3 to
87a6ca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my adventure to replace Immutables.org, I stumbled upon yet another nifty feature:
If you are setting an optional field, you are probably intending to set a concrete value.
So here is this PR that adds setters that take concrete values and wrap them in optional prior to insertion into the record.