Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added add function #63

Merged
merged 2 commits into from
May 24, 2017
Merged

Added add function #63

merged 2 commits into from
May 24, 2017

Conversation

pjona
Copy link
Collaborator

@pjona pjona commented May 23, 2017

No description provided.

@RamonSmit
Copy link
Owner

You're working quite hard on this one 👍

@RamonSmit RamonSmit merged commit 38719be into RamonSmit:master May 24, 2017
@pjona
Copy link
Collaborator Author

pjona commented May 24, 2017

@RamonSmit can you make new release on GitHub?

@pjona
Copy link
Collaborator Author

pjona commented May 24, 2017

@RamonSmit I also thinking about adding ESLint, and few events.

@RamonSmit
Copy link
Owner

New release to 1.2.5?

@pjona
Copy link
Collaborator Author

pjona commented May 24, 2017

Yes, please.

@RamonSmit
Copy link
Owner

Done :-)

@RomanBurunkov
Copy link
Contributor

RomanBurunkov commented Jun 24, 2017

Hi @pjona,

I've tested add method and found out one issue when adding item with parent_id.
When adding first child to parent with id parent_id, add method doesn't add expand/colapse buttons and further we have no chance to add then from user side. Looks like we should use setParent method which already exist. But I'm not quite sure where to add it.

@pjona
Copy link
Collaborator Author

pjona commented Jun 24, 2017

@RomanBurunkov you are right, I will try to fix it. Can you create a issue with it?

@RomanBurunkov
Copy link
Contributor

@pjona,

Issue 66 has been added ;)

Thanks, Roman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants