Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix knd on Fish #36

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Fix knd on Fish #36

merged 1 commit into from
Sep 18, 2022

Conversation

morozov
Copy link
Contributor

@morozov morozov commented Sep 18, 2022

Instead of declaring the knd function on Fish, the package overrides kcd with the implementation for knd.

Ramilito
Ramilito approved these changes Sep 18, 2022
View reviewed changes
Copy link
Owner

@Ramilito Ramilito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Ramilito Ramilito merged commit c55c73d into Ramilito:main Sep 18, 2022
@morozov morozov deleted the fish-knd branch September 18, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ramilito Ramilito Ramilito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @Ramilito