Map PV Annotations from storageClass while restore #1653
+26
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rakeshgm <[email protected]>
rakeshgm
changed the title
ShyamsundarR
approved these changes
Nov 16, 2024
| // provisionerDeletionSecretName with the values from provisionerSecretName and its namespace values. | ||
| secFromSC, exists = secretsFromSC(sc.Parameters, provisionerSecretName, provisionerSecretNamespace) | ||
| if exists { | ||
| pv.Annotations[provisionerDeletionSecretName] = secFromSC.Name |
There was a problem hiding this comment.
Use util.AddAnnotation to add annotations, which also helps deal with nil map to create one. the test failure is due to attempting to write to a nil map in this case. (here and in other lines that add the annotation).
ShyamsundarR
requested changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map PV Annotations from storageClass while restore