-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing secret propagation from manifests to policy #1471
Open
abhijeet219
wants to merge
5
commits into
RamenDR:main
Choose a base branch
from
abhijeet219:secret-propagation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeet219
force-pushed
the
secret-propagation
branch
3 times, most recently
from
June 27, 2024 14:24
8c6122e
to
eb41cd3
Compare
abhijeet219
force-pushed
the
secret-propagation
branch
3 times, most recently
from
July 15, 2024 14:50
05cb432
to
d1ba588
Compare
abhijeet219
force-pushed
the
secret-propagation
branch
3 times, most recently
from
July 30, 2024 14:20
49a7d63
to
6ebebce
Compare
asn1809
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
abhijeet219
force-pushed
the
secret-propagation
branch
6 times, most recently
from
August 13, 2024 05:56
4daca2c
to
c8a1377
Compare
abhijeet219
force-pushed
the
secret-propagation
branch
from
August 14, 2024 06:38
c8a1377
to
8c4a47c
Compare
abhijeet219
force-pushed
the
secret-propagation
branch
10 times, most recently
from
November 5, 2024 08:10
40957ab
to
0e6c685
Compare
Signed-off-by: Abhijeet Shakya <[email protected]>
Currently clusterRoles and Rolebindings corresponding to vrg, olm and mmode are being deployed through manifests. Changing that secret propagation to be handled via policy. Signed-off-by: Abhijeet Shakya <[email protected]>
Signed-off-by: Abhijeet Shakya <[email protected]>
Signed-off-by: Abhijeet Shakya <[email protected]>
Signed-off-by: Abhijeet Shakya <[email protected]>
abhijeet219
force-pushed
the
secret-propagation
branch
from
November 5, 2024 08:26
0e6c685
to
b4b478f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains following changes: