Coverage target and docs #1011
Coverage target and docs #1011
Conversation
This is a easy way to run:
go tool cover -html=cover.out
The reported coverage depends on running one of the test targets (e.g.
make test).
Signed-off-by: Nir Soffer <[email protected]>
Signed-off-by: Nir Soffer <[email protected]>
Signed-off-by: Nir Soffer <[email protected]>
nirs
requested review from
raghavendra-talur,
rakeshgm,
ShyamsundarR,
BenamarMk and
ELENAGER
|
Why do we need a coverage target? The coverage target is another target in the Makefile which is to ease understanding ho go coverage can be reported? The discussed intention was to provide a coverage report at the end, that can then be a CI routine that covers if the current PR degrades coverage from the current branch coverage. Is this leading towards the same? |
For the same reason we need all the other targets in the makefile, all of them are just trivial wrappers using some tool that the developer can use manually. We want that developers will check coverage when modifying the code and adding tests, and the way to make it happen is make it easy to inspect coverage.
Coverage report in the CI is orthogonal. This is more complicated and may require interaction with another service so it should not be the only way we have to inspect coverage. |
Add coverage target and document how to run the tests and inspect coverage.