Skip to content

Commit

Permalink
Separate build container and make venv steps
Browse files Browse the repository at this point in the history
Move `make venv` and `make docker-build` to their own step to clean up
the job output and avoid pointless operations.

This way the usually uninteresting details of these operations are
folded under a descriptive name.

Signed-off-by: Nir Soffer <[email protected]>
  • Loading branch information
nirs authored and raghavendra-talur committed Mar 7, 2024
1 parent 0beb4aa commit 9bd126d
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,20 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@v3

- name: Build ramen-operator container
run: make docker-build

- name: Create virtual environment
run: make venv

- name: Cleanup existing environment
if: ${{ always() }}
run: |
make venv
source venv
make destroy-rdr-env
- name: Run make target e2e-rdr
run: |
make docker-build
make venv
source venv
make create-rdr-env
cp ~/.config/drenv/${{ env.NAME_PREFIX }}rdr/config.yaml e2e/config.yaml
Expand All @@ -42,6 +45,5 @@ jobs:
- name: Cleanup e2e-rdr
if: ${{ always() }}
run: |
make venv
source venv
make destroy-rdr-env

0 comments on commit 9bd126d

Please sign in to comment.