Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determinism for Serialization #364

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ZagButNoZig
Copy link

@ZagButNoZig ZagButNoZig commented Jan 20, 2024

This a draft for making the serialization of a world deterministic by adding the necessary information to the serialization.
It works by saving the free list and all the generations of all alive and de spawned entities.

TODOs

  • Fix the 2 serialize test cases
  • Remove column serialize from default features
  • Make sure everything works as intended
  • Maybe add this to row serialization aswell (Out of scope for this PR)

@caspark caspark mentioned this pull request May 16, 2024
Cargo.toml Outdated Show resolved Hide resolved
src/entities.rs Outdated Show resolved Hide resolved
src/entities.rs Outdated Show resolved Hide resolved
src/entities.rs Outdated Show resolved Hide resolved
src/serialize/column.rs Outdated Show resolved Hide resolved
src/world.rs Outdated Show resolved Hide resolved
src/world.rs Outdated Show resolved Hide resolved
src/world.rs Outdated Show resolved Hide resolved
src/serialize/column.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@ZagButNoZig ZagButNoZig marked this pull request as ready for review July 8, 2024 12:31
@ZagButNoZig ZagButNoZig requested a review from Ralith July 9, 2024 07:13
@ZagButNoZig ZagButNoZig changed the title RFC: Determinism for Serialization Determinism for Serialization Jul 9, 2024
@caspark
Copy link
Contributor

caspark commented Oct 22, 2024

@Ralith is this PR sound/ready to be merged? I would benefit from having this in master too, so if it's falling short in some way then I can try to fix it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants