Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/index.md: add Feedback section (Ralim#1552) as suggested #1744

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

ia
Copy link
Collaborator

@ia ia commented Jul 17, 2023

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Update Documentation/index.md which is exported as ReadTheDocs online documentation.

  • What is the current behavior?
    As described in this report:New IronOS docs pages, add tab/method to jump to Discussions and Issue tickets. #1552, if a user opens the main online documentation page, there is no any information about feedback to the project nor how to report a bug or ask community for help.

  • What is the new behavior (if this is a feature change)?
    if a user opens the main online documentation page, there is a clear "feedback welcome" section with direct links to github Issue report form of the project and direct link to Discussions board.

  • Other information:
    Very good & smart suggestion BTW.

@Ralim Ralim enabled auto-merge (squash) July 17, 2023 22:28
@ia
Copy link
Collaborator Author

ia commented Jul 17, 2023

TL; DR: as far as I understand nuances of github, you should change some protection settings for branch dev in the original IronOS repo. Otherwise these stalled decommissioned jobs still will be in a permanent waiting status (which in its turn makes automerge is not possible).

It seems that enabling auto-merge won't do merge automatically. Although it says:

This pull request will squash and merge automatically when all requirements are met.

There is a still that little issue due to renaming jobs steps. The thing is that I did this pull-request against forked repo with fixed push.yml (so the file is a full equivalent between original & forked repo). As far as I understand the comment from the link above:

When you rename or remove jobs, you need to update any branch protection rules that use them.

In this case you should do something here for dev (probably manually disabling/removing/re-adding jobs manually or something like that).

I'm terribly sorry for this inconvenience. If I would know that github works in such strange illogical way with renamed jobs, I would keep them as is. Sorry. But on top of that, if we go to Actions tab, it even doesn't show those ghost jobs from previous push.yml revision (as it should). 🤷‍♂️

@Ralim
Copy link
Owner

Ralim commented Jul 17, 2023

Hahahah yeah dont stress I'm on it when I get to a pc later on.

@Ralim Ralim disabled auto-merge July 18, 2023 04:35
@Ralim Ralim merged commit 1d820ac into Ralim:dev Jul 18, 2023
15 checks passed
@ia
Copy link
Collaborator Author

ia commented Jul 18, 2023

Just a suggestion but I guess now you can close as fixed this:#1552 and this:#1643 issues for actualization of issue tracker BTW.

@ia ia deleted the feedback branch July 18, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants