Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try side-port of different linker and ram for PinecilV2 #1730

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Try side-port of different linker and ram for PinecilV2 #1730

merged 1 commit into from
Jul 5, 2023

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Jul 2, 2023 •
edited by discip
Loading

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?

A different tact to try and fix #1661

  • What is the current behavior?

#1661

  • What is the new behavior (if this is a feature change)?
    Uses their custom ram allocator & different linker layout
  • Other information:

@discip discip marked this pull request as ready for review July 2, 2023 11:16
@Ralim Ralim marked this pull request as draft July 2, 2023 23:20
@discip
Copy link
Collaborator

discip commented Jul 5, 2023

@Ralim
Sorry for marking this as ready for review.
That was definitely not on purpose.
I somehow managed to click that button without realizing it.

@Ralim
Copy link
Owner Author

Ralim commented Jul 5, 2023

No drama at all 😂
Don't stress about it :)

@Ralim Ralim marked this pull request as ready for review July 5, 2023 21:28
@Ralim Ralim merged commit 0be8359 into dev Jul 5, 2023
@Ralim Ralim deleted the pinecilv2-alt-linker branch July 5, 2023 21:35
@Ralim
Copy link
Owner Author

Ralim commented Jul 5, 2023

Merging this as it seems to have no negative affect for my units, and maybe improves things for others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinecil v2 doesn't work after updating to v2.21
2 participants
@Ralim @discip