Skip to content

Commit

Permalink
Auto merge of #107542 - compiler-errors:param-envs-with-inference-var…
Browse files Browse the repository at this point in the history
…s-are-cursed, r=jackh726

Don't call `with_reveal_all_normalized` in const-eval when `param_env` has inference vars in it

**what:** This slightly shifts the order of operations from an existing hack:

https://github.com/rust-lang/rust/blob/5b6ed253c42a69b93e7447fb0874a89ab6bc1cfb/compiler/rustc_middle/src/ty/consts/kind.rs#L225-L230

in order to avoid calling a tcx query (`TyCtxt::reveal_opaque_types_in_bounds`, via `ParamEnv::with_reveal_all_normalized`) when a param-env has inference variables in it.

**why:** This allows us to enable fingerprinting of query keys/values outside of incr-comp in deubg mode, to make sure we catch other places where we're passing infer vars and other bad things into query keys. Currently that (bbf33836b9adfe4328aefa108c421e670a3923b7) crashes because we introduce inference vars into a param-env in the blanket-impl finder in rustdoc 😓

https://github.com/rust-lang/rust/blob/5b6ed253c42a69b93e7447fb0874a89ab6bc1cfb/src/librustdoc/clean/blanket_impl.rs#L43

See the CI failure here: https://github.com/rust-lang/rust/actions/runs/4058194838/jobs/6984834619
  • Loading branch information
bors committed Feb 18, 2023
2 parents b2e08ad + ab299bd commit ebc2bd6
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit ebc2bd6

Please sign in to comment.