Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed navbar elements in mobile devices #609

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Fixed navbar elements in mobile devices #609

merged 3 commits into from
Feb 23, 2024

Conversation

yashi-15
Copy link
Contributor

@yashi-15 yashi-15 commented Feb 23, 2024

Fixes Issue🛠️

Closes #581

Description👨‍💻

Navbar elements are now readable in mobile devices.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested on my local machine.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Screenshot (308)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yashi-15, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 37ef079
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/65d8d50c8f91f20008444b01
😎 Deploy Preview https://deploy-preview-609--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100 Rakesh9100 changed the title Navbar elements now visible. Fixed navbar elements in mobile devices Feb 23, 2024
@Rakesh9100
Copy link
Owner

Merged ✨ @yashi-15

@Rakesh9100 Rakesh9100 merged commit 26f1a1e into Rakesh9100:main Feb 23, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion Easy IWOC2k24 (10 Points) ✨, JWOC2k24 (1 Point) 🎉, SWOC2k24 Level-1 (20 Points) 💫 JWOC JWOC 2k24 Open Source Program labels Feb 23, 2024
@yashi-15
Copy link
Contributor Author

Hey, this PR should have been merged under SWOC @Rakesh9100

@Rakesh9100 Rakesh9100 added SWOC S4 SWOC Open Source Program and removed JWOC JWOC 2k24 Open Source Program labels Feb 23, 2024
@Rakesh9100
Copy link
Owner

Done ✅ @yashi-15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Easy IWOC2k24 (10 Points) ✨, JWOC2k24 (1 Point) 🎉, SWOC2k24 Level-1 (20 Points) 💫 SWOC S4 SWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Navbar elements not readable in mobile devices
2 participants