Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Annulus Calculator #1647

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Damini2004
Copy link
Contributor

Fixes Issue🛠️

Closes # #1576

Description👨‍💻

Added Annulus Calculator

Type of Change📄

  • Bug fix (non-breaking change which fixes a bug)
  • New feature (non-breaking change which adds functionality)
  • Style (non-breaking change which improves website style or formatting)
  • Documentation (non-breaking change which updates or adds documentation)
  • Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Damini2004, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jul 14, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 34814b8
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66956f7a2d2f0900088552a7
😎 Deploy Preview https://deploy-preview-1647--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nihal4777
Copy link

@Damini2004, You should add your calculator in alphabetical order in main index.html file of the project.

@Nihal4777
Copy link

@Damini2004 UI needs to be improved little bit. Also, you have specified that you will provide diagram?
#1576 (comment),
image

@Damini2004
Copy link
Contributor Author

@Nihal4777 Changes done
Ohh i thought she was asking to give diagram of that particular formula, for diagram implemetation i need some time
KInldy review and merge it.

@Damini2004
Copy link
Contributor Author

@Nihal4777 Added.

@Nihal4777
Copy link

@Damini2004 On small screens, there is overflow.
image

@Damini2004
Copy link
Contributor Author

Yes it will overflow because the radius is increased then it not possible to visible the bigger circle. so we can provide diagram of inner circle rather than outer circle. Are you ok with it.

@Rakesh9100
Copy link
Owner

image

Where is the proper diagram, just white circle is visible. Also, that is hiding the result, pls fix @Damini2004

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jul 30, 2024
@Rakesh9100
Copy link
Owner

Are you working @Damini2004

@Rakesh9100
Copy link
Owner

Will close the PR if changes are not made today @Damini2004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question 🤔 Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants