Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency downshift to v6 - autoclosed #218

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 21, 2020

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
downshift (source) 4.0.8 -> 6.1.12 age adoption passing confidence

Release Notes

downshift-js/downshift

v6.1.12

Compare Source

Bug Fixes

v6.1.11

Compare Source

Bug Fixes

v6.1.10

Compare Source

Bug Fixes
  • useCombobox: prevent default on Escape when open or has content (#​1407) (3eb7b44)

v6.1.9

Compare Source

Bug Fixes

v6.1.8

Compare Source

Bug Fixes
  • useMultipleSelect: removeSelectedItem adding duplicate items to selected items (#​1353) (bf709b9), closes #​1316

v6.1.7

Compare Source

Bug Fixes

v6.1.6

Compare Source

Bug Fixes

v6.1.5

Compare Source

Bug Fixes

v6.1.4

Compare Source

Bug Fixes

v6.1.3

Compare Source

Bug Fixes
  • environment: use Node variable within the provided window context (#​1264) (f6a449e)

v6.1.2

Compare Source

Bug Fixes
  • useSelect: clear debounced keysSoFar callback on unmount (#​1256) (a6bcd22)

v6.1.1

Compare Source

Bug Fixes

v6.1.0

Compare Source

Features

v6.0.16

Compare Source

Bug Fixes
  • hooks: prevent overwrite of itemRefs when hooks rerender (#​1219) (4b6860e)

v6.0.15

Compare Source

Performance Improvements

v6.0.14

Compare Source

Bug Fixes

v6.0.13

Compare Source

Bug Fixes

v6.0.12

Compare Source

Performance Improvements

v6.0.11

Compare Source

Bug Fixes
  • cleanupStatus: cleanup message container when it's outside the default document (#​1204) (2edda8b)

v6.0.10

Compare Source

Bug Fixes

v6.0.9

Compare Source

Performance Improvements

v6.0.8

Compare Source

Bug Fixes

v6.0.7

Compare Source

Bug Fixes

v6.0.6

Compare Source

Bug Fixes
  • useCombobox: select item on blur only when menu is open (#​1170) (d1299c4)

v6.0.5

Compare Source

Performance Improvements

v6.0.4

Compare Source

Bug Fixes

v6.0.3

Compare Source

Bug Fixes

v6.0.2

Compare Source

Bug Fixes

v6.0.1

Compare Source

Bug Fixes

v6.0.0

Compare Source

BREAKING CHANGES
  • Update TS typings for selectedItem to accept null in both useSelect and useCombobox.

To migrate to the new change, update your types or code if necessary. selectedItem, defaultSelectedItem and initialSelectedItem now have Item | null instead of Item type. PR with the changes: https://github.com/downshift-js/downshift/pull/1090

  • Update TS typings for itemToString to accept null for the item parameter, in useSelect and useCombobox + in Downshift where this was missing. useMultipleSelection type for itemToString stays the same as it can't receive null as item.

To migrate to the new change, update your types or code if necessary. itemToString: (item: Item) => string -> itemToString: (item: Item | null) => string}. PR with the changes: https://github.com/downshift-js/downshift/pull/1075 https://github.com/downshift-js/downshift/pull/1105

  • Pass type to the onChange (onInputValueChange, onHighlightedIndexChange, onSelectedItemChange, onIsOpenChange) handler parameters, as specified in the documentation. Also updated the TS typings to reflect this + onStateChange - the type parameter was passed but it was not reflected in the TS types.

To migrate to the new change, update your types or code if necessary, better to view the changes in the PR: https://github.com/downshift-js/downshift/pull/985. Important: please update to the 6.0.2 version since it contains a couple of fixes for the changes in this Breaking Change. Final changes:

  stateReducer?: (
    state: UseComboboxState<Item>,
    actionAndChanges: UseComboboxStateChangeOptions<Item>, // UseComboboxStateChangeOptions has the correct typings
  ) => Partial<UseComboboxState<Item>> // this now reflects the correct return, which is the partial state.
  onSelectedItemChange?: (changes: UseComboboxStateChange<Item>) => void // changes have partial state + type
  onIsOpenChange?: (changes: UseComboboxStateChange<Item>) => void 
  onHighlightedIndexChange?: (changes: UseComboboxStateChange<Item>) => void
  onStateChange?: (changes: UseComboboxStateChange<Item>) => void
  onInputValueChange?: (changes: UseComboboxStateChange<Item>) => void

where

export interface UseComboboxStateChangeOptions<Item>
  extends UseComboboxDispatchAction<Item> { // type and optional parameters needed to compute the next state
  changes: Partial<UseComboboxState<Item>> // partial state changes proposed by the hook
}

export interface UseComboboxDispatchAction<Item> {
  type: UseComboboxStateChangeTypes
  shiftKey?: boolean
  getItemNodeFromIndex?: (index: number) => HTMLElement
  inputValue?: string
  index?: number
  highlightedIndex?: number
  selectedItem?: Item | null
  selectItem?: boolean
}

export interface UseComboboxStateChange<Item>
  extends Partial<UseComboboxState<Item>> {
  type: UseComboboxStateChangeTypes
}
BREAKING BEHAVIOURS

v5.4.7

Compare Source

Bug Fixes
  • useSelect: ensure the initial selected item is scrolled into view on first open (#​1113) (d7bf498)

v5.4.6

Compare Source

Bug Fixes
  • useCombobox: fix onSelectedItemChange not triggering with controlled selectedItem in React.StrictMode (#​1107) (5353265)

v5.4.5

Compare Source

Bug Fixes

v5.4.4

Compare Source

Bug Fixes
  • useCombobox: navigating up if all items are disabled (#​1087) (a71005b)

v5.4.3

Compare Source

Bug Fixes

v5.4.2

Compare Source

Bug Fixes
  • useCombobox: update inputValue when calling selectItem (#​1055) (52aad04)

v5.4.1

Compare Source

Bug Fixes

v5.4.0

Compare Source

Features

v5.3.0

Compare Source

Features

v5.2.7

Compare Source

Bug Fixes

v5.2.6

Compare Source

Bug Fixes

v5.2.5

Compare Source

Performance Improvements

v5.2.4

Compare Source

Bug Fixes

v5.2.3

Compare Source

Bug Fixes

v5.2.2

Compare Source

Bug Fixes
  • useSelect: don't trigger blur state change after item selection (#​1016) (dff18c0)

v5.2.1

Compare Source

Bug Fixes

v5.2.0

Compare Source

Features
  • hooks: align behavior of a11y status messages between hooks and Downshift (#​1004) (5525e98)

v5.1.1

Compare Source

Bug Fixes
  • useMultipleSelection: replace item with selectedItem in typings for getSelectedItemProps (#​1002) (5ad8864)

v5.1.0

Compare Source

Features

v5.0.7

Compare Source

Bug Fixes

v5.0.6

Compare Source

Bug Fixes
  • typescript: add missing scrollIntoView definitions to hooks (#​983) (75b2fb6)

v5.0.5

Compare Source

Bug Fixes
  • hooks: replace Object.entries with Object.keys to support > IE 9 (#​971) (536bebc)

v5.0.4

Compare Source

Bug Fixes
  • hooks: call onStateChange with type and only changed props (#​967) (f6a7913)

v5.0.3

Compare Source

Bug Fixes
  • hooks: only add aria-activedescendant when menu is open (#​945) (28cdc02)

v5.0.2

Compare Source

Bug Fixes

v5.0.1

Compare Source

Bug Fixes
  • useCombobox: dispatch ToggleButtonClick before focusing input (#​942) (26d426e)

v5.0.0

Compare Source

BREAKING CHANGES
  • Removed FunctionClearKeysSoFar from state change types and TS typings. In useSelect, once the timeout for keeping the character keys in memory has expired, FunctionSetInputValue will be used. We are doing this as we are renaming keysSoFar with inputValue.

To migrate to the new change, simply check for FunctionSetInputValue with empty string as inputValue instead of checking for FunctionClearKeysSoFar in stateReducer.

  • Both getA11yStatusMessage and getA11ySelectionMessage will be called with the same props as the getA11yStatusMessage in <Downshift>, apart from previousResultCount. In the TS typings it's now marked as optional, and all functions have the same interface definition, A11yStatusMessageOptions.

To migrate to the new changes, in useSelect and useCombobox, if you used items as parameters in any of the a11y message functions, now you should use resultCount as probably you only needed items.length from it anyway.

Also typings UseSelectA11yMessageOptions and UseComboboxA11yMessageOptions have been removed. Use A11yStatusMessageOptions instead.

Code Changes: tests have been enhanced by using user input from RTL and they now look better and cleaner. Also covered more use cases better. Code has been refactored as well, and bundle size slightly reduced.

Functional Improvement: better focus management for both useSelect and useCombobox.

Fixes https://github.com/downshift-js/downshift/issues/832.
Closes https://github.com/downshift-js/downshift/issues/892
Closes https://github.com/downshift-js/downshift/issues/891
Closes https://github.com/downshift-js/downshift/issues/873

v4.1.0

Compare Source

Features
  • hooks: add aria-selected="false" to each non-highlighted item (#​929) (860da10)

v4.0.11

Compare Source

Bug Fixes

v4.0.10

Compare Source

Bug Fixes
  • useSelect: dispatch closure issue on search by key (#​923) (653dbfd)

v4.0.9

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@coveralls
Copy link

coveralls commented Jul 21, 2020

Pull Request Test Coverage Report for Build 3123941889

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.915%

Totals Coverage Status
Change from base Build 2552293261: 0.0%
Covered Lines: 184
Relevant Lines: 278

💛 - Coveralls

@codeclimate
Copy link

codeclimate bot commented Jul 21, 2020

Code Climate has analyzed commit 03e3460 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 66.1% (0.0% change).

View more on Code Climate.

@renovate renovate bot force-pushed the renovate/downshift-6.x branch 8 times, most recently from bd55e19 to b35ee06 Compare July 28, 2020 21:36
@renovate renovate bot force-pushed the renovate/downshift-6.x branch 7 times, most recently from 5b203a1 to 6a218a5 Compare August 6, 2020 21:53
@renovate renovate bot force-pushed the renovate/downshift-6.x branch 7 times, most recently from ca9c6fa to 2818638 Compare August 15, 2020 10:34
@renovate renovate bot force-pushed the renovate/downshift-6.x branch 5 times, most recently from a113527 to 7a2f31c Compare August 22, 2020 12:47
@renovate renovate bot force-pushed the renovate/downshift-6.x branch 4 times, most recently from 1f74bb2 to 4d41551 Compare January 22, 2021 03:42
@renovate renovate bot force-pushed the renovate/downshift-6.x branch 3 times, most recently from abd1b3d to 08b38f6 Compare February 3, 2021 04:08
@renovate renovate bot force-pushed the renovate/downshift-6.x branch 4 times, most recently from d3fd6ec to 0d0b986 Compare February 14, 2021 23:31
@renovate renovate bot force-pushed the renovate/downshift-6.x branch 5 times, most recently from 79b5fa7 to 242cd5f Compare February 23, 2021 04:57
@renovate renovate bot force-pushed the renovate/downshift-6.x branch 2 times, most recently from e991db1 to bb8a0a3 Compare March 1, 2021 23:23
@renovate renovate bot changed the title fix(deps): update dependency downshift to v6 fix(deps): update dependency downshift to v6 - autoclosed Nov 20, 2022
@renovate renovate bot closed this Nov 20, 2022
@renovate renovate bot deleted the renovate/downshift-6.x branch November 20, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant