Skip to content
This repository has been archived by the owner on Mar 23, 2022. It is now read-only.

UI lag on section expansion #344

Closed
RaenonX opened this issue Jan 8, 2022 · 1 comment · Fixed by #351
Closed

UI lag on section expansion #344

RaenonX opened this issue Jan 8, 2022 · 1 comment · Fixed by #351
Assignees
@RaenonX
Labels
Enhancements

Comments

@RaenonX
Copy link
Member

RaenonX commented Jan 8, 2022

https://dl.raenonx.cc/cht/misc/24

Try rendering the items but hide them first. See if there is any performance impact on page load.
@RaenonX RaenonX self-assigned this Jan 8, 2022
RaenonX added a commit that referenced this issue Jan 12, 2022
@RaenonX
Fixed UI lag on section expansion #344
03031ef 
Signed-off-by: RaenonX <[email protected]>
RaenonX added a commit that referenced this issue Jan 12, 2022
@RaenonX
Fixed UI lag on section expansion #344
73bc85d 
Signed-off-by: RaenonX <[email protected]>
@RaenonX
Copy link
Member Author

RaenonX commented Jan 12, 2022

The fix in 73bc85d is a dirty fix because it uses React.useState to store the rendered JSX.

@RaenonX RaenonX closed this as completed Jan 12, 2022
@RaenonX RaenonX mentioned this issue Jan 12, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RaenonX RaenonX

Labels
Enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.17.0-beta.2 Release RaenonX-DL/dragalia-site-front
1 participant
@RaenonX