Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to #1502 #1503

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Minor fixes to #1502 #1503

wants to merge 3 commits into from

Conversation

kartographer
Copy link
Contributor

Description

Fixes a couple of tests that broke in #1502.

Motivation and Context

I'm not quite sure how it managed to pass by (both locally on laptop but also in CI), but #1502 actually broke a couple of tests since ATA was introduced as a new known telescope. I only noticed this when attempting a rebase -- not sure what to make of the CI behavior, but that's to be addressed outside of this PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (6138b9a) to head (51ce150).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1503   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          63       63           
  Lines       21834    21834           
=======================================
  Hits        21819    21819           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton added bug docs documentation labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants