Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Adding the Pytorch install options #134

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anubhavamd
Copy link
Contributor

@anubhavamd anubhavamd marked this pull request as ready for review November 12, 2021 17:16
@anubhavamd anubhavamd marked this pull request as draft November 12, 2021 17:17
@anubhavamd
Copy link
Contributor Author

@amathews-amd can you please review this.

@@ -286,21 +286,16 @@ Note: Currently, ROCm install version 3.3 is required.
Recommended: Install using published PyTorch ROCm docker image:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Currently, ROCm install version 3.3 is required ?

@@ -286,21 +286,16 @@ Note: Currently, ROCm install version 3.3 is required.
Recommended: Install using published PyTorch ROCm docker image:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Recommended: Install using published PyTorch ROCm docker image: to
Option 1 (Recommended): Install using published PyTorch ROCm docker image:

Install or update rocm-dev on the host system: should be it's own thing since its required for all 3 options.

@@ -318,182 +313,82 @@ Recommended: Install using published PyTorch ROCm docker image:
This step is optional but most PyTorch scripts will use torchvision to load models. E.g., running the pytorch examples requires torchvision.


Option 2: Install using PyTorch upstream docker file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 2 title is missing

@amathews-amd
Copy link

Keep same formatting in new additions as previous doc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants