Merge pull request #1 from alamb/alamb/tweak-group

Do not re-validate output is utf8
Rachelint · Oct 13, 2024 · f76c376 · f76c376
2 parents e6c7e7e + 36d556e
commit f76c376
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/datafusion/physical-plan/src/aggregates/group_values/group_column.rs b/datafusion/physical-plan/src/aggregates/group_values/group_column.rs
@@ -592,11 +592,17 @@ impl<B: ByteViewType> ByteViewGroupValueBuilder<B> {
 
         let views = ScalarBuffer::from(views);
 
-        Arc::new(GenericByteViewArray::<B>::new(
-            views,
-            completed,
-            null_buffer,
-        ))
+        // Safety:
+        // * all views were correctly made
+        // * (if utf8): Input was valid Utf8 so buffer contents are
+        // valid utf8 as well
+        unsafe {
+            Arc::new(GenericByteViewArray::<B>::new_unchecked(
+                views,
+                completed,
+                null_buffer,
+            ))
+        }
     }
 
     fn take_n_inner(&mut self, n: usize) -> ArrayRef {