Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

57 class attribute api #59

Merged
merged 3 commits into from
Aug 29, 2022
Merged

57 class attribute api #59

merged 3 commits into from
Aug 29, 2022

Conversation

FWuellhorst
Copy link
Collaborator

Does not solve #57, but avoids usage of dicts, which is quite confusing to begin with.

KBeeser pushed a commit that referenced this pull request Aug 23, 2022
implement changes of issue #59
17c8589 
adjsut examples to include experiment configuration
KBeeser
KBeeser approved these changes Aug 23, 2022
View reviewed changes
Copy link

@KBeeser KBeeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid off the dictionaries for fmu/dymola instances and unzip directories improves understandability.
I tested the changes on the current code of #55 and it works.
Also, the changes enable the instantiation of multiple FMU API classes, which is required for #38 and #55 (co-simulation).

@FWuellhorst
Copy link
Collaborator Author

Thanks for the review! It seems like I messed up local commits during fixing the CI in the master branch. Thats why the FMU was already in the master.

@FWuellhorst FWuellhorst merged commit 95e414b into master Aug 29, 2022
@FWuellhorst FWuellhorst deleted the 57_classAttributeAPI branch December 15, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KBeeser KBeeser KBeeser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FWuellhorst @KBeeser