Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

222 integration of ngsi ld endpoints #247

Closed
wants to merge 120 commits into from

Conversation

djs0109
Copy link
Contributor

@djs0109 djs0109 commented Feb 20, 2024

close #222

Malte96 and others added 30 commits November 2, 2023 15:35
Addes reference to readme
edit authors and alumni
adjusted copyright year
# Conflicts:
#	filip/models/base.py
Add authorization field to fiware-header
…ible-with-Pydantic-v2

fix: updated regex to pattern
@iripiri
Copy link
Collaborator

iripiri commented Jun 12, 2024

Endpoints (implemented & tested):

Entities

  • GET /entities
  • POST /entities
  • GET /entities/{entityId}
  • DELETE /entities/{entityId}
  • POST /entities/{entityId}/attrs
  • PATCH /entities/{entityId}/attrs
  • PATCH /entities/{entityId}/attrs/{attrId}
  • DELETE /entities/{entityId}/attrs/{attrId}

Batch operations

  • POST /entityOperations/create
  • POST /entityOperations/update
  • POST /entityOperations/upsert
  • POST /entityOperations/delete

Subscriptions

  • GET /subscriptions
  • POST /subscriptions
  • GET /subscriptions/{subscriptionId}
  • PATCH /subscriptions/{subscriptionId}
  • DELETE /subscriptions/{subscriptionId}

filip/clients/ngsi_ld/cb.py Outdated Show resolved Hide resolved
tests/models/test_ngsi_ld_entities.py Outdated Show resolved Hide resolved
tests/models/test_ngsi_ld_entities.py Outdated Show resolved Hide resolved
tests/models/test_ngsi_ld_entities.py Outdated Show resolved Hide resolved
tests/models/test_ngsi_ld_entities.py Outdated Show resolved Hide resolved
tests/models/test_ngsi_ld_entities.py Show resolved Hide resolved
Copy link
Contributor Author

@djs0109 djs0109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iripiri is it possible to move the files test_ngsi_ld_subscription.py test_ngsi_ld_entity_batch_operation.py and test_ngsi_ld_entities.py to FiLiP\tests\clients ? They are now actually in a folder for the tests of data models

@djs0109
Copy link
Contributor Author

djs0109 commented Jun 25, 2024

I have modified these tests (mainly in setUp( ) function) so that a context-broker client object is always created there, using the environment variables from settings. @iripiri could you check this commit 34a7223, and let me know whether this convention also make sense to you?

@iripiri
Copy link
Collaborator

iripiri commented Jun 25, 2024

I have modified these tests (mainly in setUp( ) function) so that a context-broker client object is always created there, using the environment variables from settings. @iripiri could you check this commit 34a7223, and let me know whether this convention also make sense to you?

Yes, looks good!

@iripiri
Copy link
Collaborator

iripiri commented Jun 25, 2024

@iripiri is it possible to move the files test_ngsi_ld_subscription.py test_ngsi_ld_entity_batch_operation.py and test_ngsi_ld_entities.py to FiLiP\tests\clients ? They are now actually in a folder for the tests of data models

Hi Junsong, yes they should move to the folder. I have now switched over to branch #287 , to continue the Test Cases with Lara's latest changes. She already moved the files

@djs0109
Copy link
Contributor Author

djs0109 commented Jun 25, 2024

@iripiri great, that sounds good. So the branch 212-testcase-for-every-endpoint-1 in #287 will be further developed and ultimately merged to NGSI-LD main branch, is that the plan?

@djs0109
Copy link
Contributor Author

djs0109 commented Jun 26, 2024

Close because the development will be continued in #212

@djs0109 djs0109 closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.