-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1520 new hp models #1532
1520 new hp models #1532
Conversation
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
Corrected HTML Code in branch correct_HTML_1520_newHPModels
…ion reference files. Please pull the new files before push again. Plottet Results /1520_newHPModels/charts/
…into 1520_newHPModels
…ion reference files. Please pull the new files before push again. Plottet Results /1520_newHPModels/charts/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MZuschlag
As discussed briefly already, I moved the old models to obsolete and adjusted the old performance data to the new format. This PR seems huge, but it is mainly moving the HeatPump, Chiller, and HeatPumpSystem to obsolete. Please check if the old examples still work for you (Obsolete is still tested in CI, so nothing changed) and if the new models, especially AixLib.Fluid.HeatPumps.ModularReversible.RefrigerantCycle.TableData3D
is clear and useable. This was not yet reviewed in IBPSA.
If you have questions about the new approach and how to adopt your modules to it, we can also schedule a meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments
...id/HeatPumps/ModularReversible/Data/TableDataSDF/TableData3D/VCLibPy/VCLibStandardPropane.mo
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly general question adressing heat pump modeling in general.
AixLib/Resources/Data/Fluid/HeatPumps/ModularReversible/Data/VCLibMap/create_vclib_map.py
Show resolved
Hide resolved
AixLib/Fluid/HeatPumps/ModularReversible/Data/TableData2D/EN14511/AlphaInnotec_LW80MA.mo
Show resolved
Hide resolved
AixLib/Obsolete/Year2024/DataBase/Chiller/PerformanceData/LookUpTableND.mo
Show resolved
Hide resolved
AixLib/Obsolete/Year2024/DataBase/HeatPump/EN14511/AlphaInnotec_LW80MA.mo
Show resolved
Hide resolved
AixLib/Obsolete/Year2024/DataBase/HeatPump/Functions/Characteristics/PartialBaseFct.mo
Show resolved
Hide resolved
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/1520_newHPModels/charts |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/1520_newHPModels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /1520_newHPModels/charts/
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/1520_newHPModels/charts |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/1520_newHPModels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /1520_newHPModels/charts/
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/1520_newHPModels/charts |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/1520_newHPModels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /1520_newHPModels/charts/
…into 1520_newHPModels
Closes #1520
Closes #1531 (with c216e97)
Closes #1507
Closes #1128
Closes #1347
Closes #1462
Closes #1128