issue1494: fix missing parameter bindings #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FWuellhorst
reviewed
Jun 12, 2024
| @@ -226,12 +226,6 @@ model Chiller "Base model of FastHVAC Chiller" | |||
| extent={{6,-6},{-6,6}}, | |||
| rotation=90, | |||
| origin={16,-52}))); | |||
| Modelica.Blocks.Interfaces.RealInput iceFac_in if not useBusConnectorOnly | |||
There was a problem hiding this comment.
Please revert this change, this should not impact OM
|
@jonas0902 : Can you check the model |
|
Errors in regression test. Compare the results on the following page |
FWuellhorst
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1494
Missing parameter bindings have been added in the form of default parameters.
Redundant conditional arguments in a non-connect context have been removed.