1426 non standard annotation phe #1466
Conversation
changed CalcMethodRadiativeHeatTransfer.mo
Changed CalcMethodConvectiveHeatTransfer.mo, CalcMethodConvectiveHeatTransferInsideSurface.mo, CalcMethodLongwaveRadiationHeatTransfer.mo, SurfaceOrientation.mo
…tion_tsp' into 1426-non-standard-annotation-phe
Changed ThermalInsulationRegulation.mo
HighOrder Model
Changed all radioButtons in HOM
…ditions" #1426 change radioButtons to checkBoxes if number of choices equals two. change radioButtons to enumerations if number of choices is greater than two.
…tion_tsp' into 1426-non-standard-annotation-phe
.../BoundaryConditions/InternalGains/Examples/InternalGains/BaseClasses/PartialHumansExample.mo
Outdated
Show resolved
Hide resolved
...oundaryConditions/WeatherData/Old/WeatherTRY/RadiationOnTiltedSurface/RadOnTiltedSurf_Liu.mo
Outdated
Show resolved
Hide resolved
...ndaryConditions/WeatherData/Old/WeatherTRY/RadiationOnTiltedSurface/RadOnTiltedSurf_Perez.mo
Outdated
Show resolved
Hide resolved
AixLib/BoundaryConditions/WeatherData/Old/WeatherTRY/Weather.mo
Outdated
Show resolved
Hide resolved
AixLib/ThermalZones/HighOrder/Components/Walls/BaseClasses/ConvNLayerClearanceStar.mo
Outdated
Show resolved
Hide resolved
...Zones/HighOrder/House/OFD_MiddleInnerLoadWall/BuildingEnvelope/UpperFloorBuildingEnvelope.mo
Show resolved
Hide resolved
|
implemented the required changes. |
|
Errors in regression test. Compare the results on the following page |
|
Tobias implemented the required changes from the last review, I fixed a wrong calculation method due to which the regression tests for HOM ASHRAE failed. I also changed the assignments in the pool model to enumerations |
There was a problem hiding this comment.
@PatrickHenkel Thanks for the implementation.
I don't think conversion scripts work in this case (https://github.com/RWTH-EBC/AixLib/wiki/Conversion-Scripts) as the type changes from Integer to Enumeration. Thus, could you increase the version number of the AixLib (in AixLib\package.mo) to 1.4.0? This way, users will get a wrong version warning when loading the latest development.
They will get warnings like this, but the equality will still work.
This pull request solves issue #1440. All instances of radioButtons in HOM are changed to enumerations. All hard-coded integer variables are changed to enumeration instances. There are more instances of radioButtons in the AixLib, which will be reworked in issue #1426.