Issue1320 add example for ahu control #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Errors in regression test. Compare the results on the following page |
LauraMaier
requested changes
Oct 19, 2022
AixLib/Resources/LowOrder_ExampleData/SIA2024_SingleOffice_week.txt
Outdated
Show resolved
Hide resolved
|
Overall great work and good example :) Just some minor change request from my side with the one linking the simulate and plot script being the most important one ;-) |
…ation. Add information to documentation for nominal values used.
LauraMaier
reviewed
Oct 21, 2022
| @@ -0,0 +1,290 @@ | |||
| within AixLib.Systems.ModularAHU.Examples; | |||
| model DemandControlledAHU "Example for air hanling unit with demand controlled ventilation" | |||
LauraMaier
previously approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Please undo the unnecessary commits with the connect statement annotations and fix typo. Then you are good to go.
Great work, thanks @martinkremer :)
LauraMaier
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1320
With his pull-request we will add a new example for
AixLib.Systems.ModularAHU.GenericAHU. The example combines the air handling unit model with a thermal zone and a DCV-strategy.A new controller is added containing the CO2-based DCV and the already existing AHU-control.
Some database for the thermal zone and a record for internal gains in single offices according to SIA 2024 is also added.