Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue1346 Hydraulic Modules fail in Open Modelica #1359

Merged
merged 13 commits into from
Oct 14, 2022
Merged

issue1346 Hydraulic Modules fail in Open Modelica #1359

merged 13 commits into from
Oct 14, 2022

Conversation

KremerMartin
Copy link
Contributor

Closes #1346

This PR should solve the openModelica problems for hydraulic modules

@KremerMartin KremerMartin self-assigned this Oct 13, 2022
@KremerMartin KremerMartin added the OpenModelica Related to usage in OM label Oct 13, 2022
@KremerMartin KremerMartin added this to the Hackday 10.2022 milestone Oct 13, 2022
@KremerMartin
Copy link
Contributor Author

  • Injection circuit model still fails in check: Internal error Instantiation of AixLib.Systems.HydraulicModules.Injection failed with no error message. ; but AixLib.Systems.HydraulicModules.Example.Injection checks and simulates.

@KremerMartin
Copy link
Contributor Author

@FWuellhorst I would suggest to wait with the review/merge until the pump models are corrected in #1352

@KremerMartin
Copy link
Contributor Author

@FWuellhorst I have changed the Documentation from pump model to make an commit. Sorry, is a little bit messy, but was the most reasonable commit.
If the ci-check is succesful, you could review this.

FWuellhorst
FWuellhorst approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the ci runs, everything should be ok! Thanks for the fixes :)

@ebc-aixlib-bot
Copy link
Contributor

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1346_HydraulicModulesOM/plots

@FWuellhorst
Copy link
Contributor

@martinkremer : You can go ahead and merge. The error in CI is due to a change in the openModelicaProject branch. We will deal with it in there.

@KremerMartin KremerMartin merged commit 7167b4d into openModelicaProject Oct 14, 2022
@KremerMartin KremerMartin deleted the issue1346_HydraulicModulesOM branch October 14, 2022 06:57
@KremerMartin KremerMartin mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FWuellhorst FWuellhorst FWuellhorst approved these changes

Assignees

@KremerMartin KremerMartin

Labels
OpenModelica Related to usage in OM
Projects
None yet
Milestone
Hackday 10.2022
Development

Successfully merging this pull request may close these issues.
4 participants
@KremerMartin @ebc-aixlib-bot @FWuellhorst @martinkremer