Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEM-243: v2 server launch #23

Merged
merged 6 commits into from
Feb 24, 2019
Merged

TEM-243: v2 server launch #23

merged 6 commits into from
Feb 24, 2019

Conversation

bonedaddy
Copy link
Contributor

@bonedaddy bonedaddy commented Feb 23, 2019

Purpose:

Allow providing needed parameters to Lensv2 server launch.

Depends on config#24

Changes:

  • include storepath when launching v2 server
  • include basic queue settings when launching v2 server
  • use config to provide the above parameters

todo before merge:

  • after config#24 is merged, cut new config release and update dependency

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #23 into master will increase coverage by 1.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage    74.9%   76.33%   +1.43%     
==========================================
  Files          15       15              
  Lines         765      786      +21     
==========================================
+ Hits          573      600      +27     
+ Misses        149      143       -6     
  Partials       43       43
Impacted Files Coverage Δ
v2_util.go 81.81% <0%> (+3.73%) ⬆️
v2.go 94.96% <0%> (+3.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5236f...9c71f4b. Read the comment docs.

@bonedaddy bonedaddy changed the title Fix v2 Server Launch (wip) Fix v2 Server Launch Feb 24, 2019
@bobheadxi bobheadxi changed the title Fix v2 Server Launch TEM-243: v2 server launch Feb 24, 2019
Copy link
Contributor

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bonedaddy bonedaddy merged commit a067b1d into master Feb 24, 2019
@bonedaddy bonedaddy deleted the fix/v2#runserver branch February 24, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants