Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support compile with mlibc #9818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support compile with mlibc #9818

wants to merge 1 commit into from

Conversation

0Bitbiscuits
Copy link
Contributor

@0Bitbiscuits 0Bitbiscuits commented Dec 22, 2024 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

支持mlibc与rtthread的编译
目前仅支持编译rt-thread, 编译rt-smart由后续进一步提交

你的解决方案是什么 (what is your solution)

添加相关头文件

请提供验证的bsp和config (provide the config and bsp)

  • BSP:qemu-vexpress-a9
  • .config: PKG_USING_MLIBC
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [*] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [ *] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [* ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [* ] 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [* ] 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [* ] 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [ *] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [* ] 代码是高质量的 Code in this PR is of high quality
  • [* ] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

mysterywolf
mysterywolf requested changes Dec 22, 2024
View reviewed changes
components/libc/compilers/mlibc/SConscript
if GetDepend("RT_USING_SMART"):
CPPPATH += [cwd + '/smart']
CPPPATH += [cwd + '/smart/sys']
print(CPPPATH)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个printf删除

components/libc/compilers/mlibc/SConscript
CPPPATH += [cwd + '/smart']
CPPPATH += [cwd + '/smart/sys']
print(CPPPATH)
CPPDEFINES = ['RT_USING_MLIBC', 'RT_USING_LIBC'] # identify this is Newlib, and only enable POSIX.1-1990
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个注释有问题 删掉

components/libc/compilers/mlibc/SConscript
print(CPPPATH)
CPPDEFINES = ['RT_USING_MLIBC', 'RT_USING_LIBC'] # identify this is Newlib, and only enable POSIX.1-1990
# LIBS = ['c', 'm'] # link libc and libm
AddDepend(['RT_USING_PICOLIBC', 'RT_USING_LIBC'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个AddDepend有问题，没有picolibc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysterywolf mysterywolf mysterywolf requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0Bitbiscuits @mysterywolf