Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt][SDIO_MAX_FREQ redundant define del] #9789

Merged

Conversation

vangao-gg
Copy link
Contributor

@vangao-gg vangao-gg commented Dec 18, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

我在测试stm32和at32的sdio驱动sd卡的文件读写的时候,发现文件读写速度不如预期;于是参考论坛文章,将
sdioMaxFreq的速度修改为24000000,但是没有生效,后面才发现,这个sdio.h的头文件中有两处SDIO_MAX_FREQ的宏定义,而我修改的是下面那一处,所以没有生效;
https://club.rt-thread.org/ask/question/b9257a9b2467df77.html

你的解决方案是什么 (what is your solution)

删除多余的SDIO_MAX_FREQ宏定义(有些板子的库文件就只有一处这个宏定义,比如hc32);
其实也可以在kconfig中加入SDIO_MAX_FREQ宏定义,但是大多数bsp的template是没有这个kconfig的;

请提供验证的bsp和config (provide the config and bsp)

  • .config:
  • action:
    没看明白
    ]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP BSP: AT32 BSP related with AT32 labels Dec 18, 2024
@vangao-gg
Copy link
Contributor Author

@Rbb666

@Rbb666 Rbb666 self-requested a review December 18, 2024 02:21
@Rbb666 Rbb666 merged commit 68221df into RT-Thread:master Dec 21, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: AT32 BSP related with AT32 BSP: STM32 BSP related with ST/STM32 BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants