[opt][SDIO_MAX_FREQ redundant define del] #9789
Merged
+0
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
我在测试stm32和at32的sdio驱动sd卡的文件读写的时候,发现文件读写速度不如预期;于是参考论坛文章,将
sdioMaxFreq的速度修改为24000000,但是没有生效,后面才发现,这个sdio.h的头文件中有两处SDIO_MAX_FREQ的宏定义,而我修改的是下面那一处,所以没有生效;
https://club.rt-thread.org/ask/question/b9257a9b2467df77.html
你的解决方案是什么 (what is your solution)
删除多余的SDIO_MAX_FREQ宏定义(有些板子的库文件就只有一处这个宏定义,比如hc32);
其实也可以在kconfig中加入SDIO_MAX_FREQ宏定义,但是大多数bsp的template是没有这个kconfig的;
请提供验证的bsp和config (provide the config and bsp)
无
没看明白
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up