[bsp][ESP32C3] support soft i2c and rt_hw_us_delay #9751
Conversation
|
yml加一下配置 |
| @@ -14,8 +14,9 @@ devices.uart: | |||
| devices.i2c: | |||
| kconfig: | |||
| - CONFIG_RT_USING_I2C=y | |||
| - CONFIG_BSP_USING_I2C=y | |||
| - CONFIG_BSP_USING_I2C0=y | |||
| - CONFIG_BSP_USING_HW_I2C=y | |||
There was a problem hiding this comment.
为什么这里选HWI2c？
之前在 #9643 (comment) 问过模块冲突是否分别写ci，但是一起写是允许的，既然这样那就把软件硬件i2c都测一遍吧
There was a problem hiding this comment.
分开写比较合理一些。检查一下ci是否测试到该swi2c.c和hw_i2c文件
There was a problem hiding this comment.
这里缺个CONFIG_BSP_USING_I2C配置。
| @@ -17,6 +17,9 @@ if GetDepend('BSP_USING_ADC'): | |||
|
|
|||
| if GetDepend('BSP_USING_I2C'): | |||
There was a problem hiding this comment.
这里BSP USING I2C有kconfig对应吗？我看到上面BSP_USING_I2C0 已经删掉了。
There was a problem hiding this comment.
这里BSP USING I2C有kconfig对应吗？我看到上面BSP_USING_I2C0 已经删掉了。
有的
menuconfig BSP_USING_I2C
bool "Enable I2C"
default n
select RT_USING_I2C
if BSP_USING_I2C
config BSP_USING_HW_I2C
bool "Enable HardWare I2C"
default nThere was a problem hiding this comment.
那选择BSP_USING_I2C 默认添加drv_hw_i2c.c ？
|
感谢提交PR， |
| @@ -17,6 +17,9 @@ if GetDepend('BSP_USING_ADC'): | |||
|
|
|||
| if GetDepend('BSP_USING_I2C'): | |||
There was a problem hiding this comment.
那选择BSP_USING_I2C 默认添加drv_hw_i2c.c ？
| @@ -14,8 +14,9 @@ devices.uart: | |||
| devices.i2c: | |||
| kconfig: | |||
| - CONFIG_RT_USING_I2C=y | |||
| - CONFIG_BSP_USING_I2C=y | |||
| - CONFIG_BSP_USING_I2C0=y | |||
| - CONFIG_BSP_USING_HW_I2C=y | |||
There was a problem hiding this comment.
这里缺个CONFIG_BSP_USING_I2C配置。
|
|
|
这个hw_i2c代码在我机器上也报warning，我之前曾经尝试过修改，但貌似会破坏原有功能（我不清楚时什么情况）。没改之前会传输7个bit，改之后就收不到任何消息了 |
|
commit 建议用命令 |
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
#5941
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up