-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bsp][cvitek] update the arm core project #9749
Conversation
#define DRV_IOUNMAP(addr) rt_iounmap(addr) | ||
#else | ||
#ifdef ARCH_ARM | ||
#include <ioremap.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
前面 #ifdef RT_USING_SMART
的时候已经包含了这个头文件
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里感觉似乎不那么对的样子。是说, 非smart环境下,aarch64下也需要做ioremap吗?如果是这样,似乎riscv64下也应该做ioremap啊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所以没开smart rv这边可以不用做ioremap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libcpu/aarch64/common/setup.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个修改影响了 common 的逻辑,不适合和这个 duo 特定的 pr 一起合入,请另外提一个 pr 并详细说明修改的理由。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9771 Accept and Done!
bsp/cvitek/drivers/drv_ioremap.h
Outdated
#define DRV_IOREMAP(addr, size) rt_ioremap(addr, size) | ||
#define DRV_IOUNMAP(addr) rt_iounmap(addr) | ||
#else | ||
#define DRV_IOREMAP(addr, size) (addr) | ||
#define DRV_IOUNMAP(addr) | ||
#endif | ||
#endif /* ARCH_ARM */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你是想表达对于 ARCH_ARM, 无论是否 smart 都要 ioremap 么?是否可以写成下面这个样子更清楚点:
#if defined RT_USING_SMART || defined ARCH_ARM
#include <ioremap.h>
#define DRV_IOREMAP(addr, size) rt_ioremap(addr, size)
#define DRV_IOUNMAP(addr) rt_iounmap(addr)
#else
#define DRV_IOREMAP(addr, size) (addr)
#define DRV_IOUNMAP(addr)
#endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
见上面的 comments
ba366fa
to
2e9fd5a
Compare
此 pr 合并前须先合并 #9771 ,否则还是会存在编译报错 |
3 个问题: 2) 请补全 commit 信息。具体要求参考:https://github.com/plctlab/plct-rt-thread/tree/notes/0.notes#%E5%A6%82%E4%BD%95%E6%8F%90%E4%BA%A4-git-commit |
已经在 #9835 中解决了,关闭这个 PR |
拉取/合并请求描述:(PR description)
[
Fixed: #9694
更新 cvitek bsp 的ARM核相关工程文件。
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
#include <smp_call.h>
导致找不到rt_hw_spinlock_t数据类型。请提供验证的bsp和config (provide the config and bsp)
BSP:
.config:
action:
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up