Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcpu][drivers] cortex-r52 abnormal takeover and software rtc naming change #9721

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

kurisaW
Copy link
Contributor

@kurisaW kurisaW commented Nov 28, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

1.R52异常触发接管
2.软件rtc修改默认设备名,防止与硬件rtc设备命名冲突
3.rsk-rzn2l支持studio编译下载

注意:如果需要使用硬件rtc alarm功能,需要关闭软件rtc;同时注意cmd_rtc_sync默认为软件rtc功能

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@kurisaW kurisaW marked this pull request as ready for review November 28, 2024 09:19
@kurisaW kurisaW requested a review from Rbb666 as a code owner November 28, 2024 10:28
@github-actions github-actions bot added BSP BSP: Renesas BSP related with Renesas labels Nov 28, 2024
/* The memory information for each device is done in memory regions file.
* The starting address and length of memory not defined in memory regions file are defined as 0. */

/* generated memory regions file - do not edit */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥要改这块?

@Rbb666 Rbb666 merged commit 2c3ee65 into RT-Thread:master Dec 4, 2024
45 of 46 checks passed
@kurisaW kurisaW deleted the r52 branch December 4, 2024 02:11
@Ryan-CW-Code
Copy link
Contributor

软件rtc不应该重命名的,软件rtc和硬件rtc本身是二选一的。
重命名后set_dateset_timestamp等许多函数包括ctime都需要适配硬件和软件rtc两种形式。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants