Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components][lwip] add support for independent dns services for multiple network devices #9433

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

Evlers
Copy link
Contributor

@Evlers Evlers commented Sep 13, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

在使用多个网络设备时,dns servers会被DHCP应答处理设置到所有网络设备

  • 在使用WiFi + ETH + PPP三个网络设备的情况下,WiFiETH往往使用的是网关作为DNS服务器
  • WiFiETH发起DHCP请求时,PPP设备(GSM模组)的DNS服务器也会被设置到WiFiETH网关IP
  • 如果默认的网络PPP网络设备,那么发起的DNS请求会到WiFi/ETH网关IP去,导致gethostbyname超时

以下是修改前的DNS IP

msh />dns
network interface device: e0 (Default)
dns server #0: 202.96.128.86
dns server #1: 202.96.134.133

network interface device: w0
dns server #0: 202.96.128.86
dns server #1: 202.96.134.133

network interface device: w1
dns server #0: 0.0.0.0
dns server #1: 0.0.0.0

network interface device: pp
dns server #0: 202.96.128.86
dns server #1: 202.96.134.133
  • 由于GSM启动较慢,WiFiETH先获取到了DNS,而后面启动的PPP网络设备WiFiETHDNS都给改掉了
  • 且等待一段时间后,WiFiETH再次发起DHCP请求时,PPP网络设备DNS会被换成WiFiETHDNS
msh />dns
network interface device: e0 (Default)
dns server #0: 192.168.1.1
dns server #1: 192.168.0.1

network interface device: w0
dns server #0: 192.168.1.1
dns server #1: 192.168.0.1

network interface device: w1
dns server #0: 0.0.0.0
dns server #1: 0.0.0.0

network interface device: pp
dns server #0: 192.168.1.1
dns server #1: 192.168.0.1

你的解决方案是什么 (what is your solution)

添加独立的DNS Servers支持,每个网络设备都有自己的DNS,使用默认网络设备的DNS并在udp中绑定对应网络设备

  • dns.c文件的dns_send函数中,读取默认网络设备dns servers并在发起udp数据前绑定该dns servers对应的网络设备
  • DHCP应答中使用netdev_set_dns_server来设置对应网卡的DNS,而不是使用dns_setserver修改所有网络设备DNS

以下是修改后的DNS IP

msh />dns
network interface device: e0 (Default)
dns server #0: 192.168.1.1
dns server #1: 192.168.0.1

network interface device: w0
dns server #0: 192.168.1.1
dns server #1: 192.168.0.1

network interface device: w1
dns server #0: 0.0.0.0
dns server #1: 0.0.0.0

network interface device: pp
dns server #0: 202.96.128.86
dns server #1: 202.96.134.133

请提供验证的bsp和config (provide the config and bsp)

  • BSP:GD32F470
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Evlers Evlers changed the title add support for independent dns services for multiple network devices [components][lwip] add support for independent dns services for multiple network devices Sep 13, 2024
@mysterywolf
Copy link
Member

@zmshahaha 麻烦review一下呗 谢谢~

@Rbb666
Copy link
Member

Rbb666 commented Sep 24, 2024

@Yaochenger 可以帮忙测试下嘛,谢谢

Evlers added a commit to Evlers/rt-thread that referenced this pull request Oct 8, 2024
@Rbb666 Rbb666 closed this Dec 25, 2024
@Rbb666 Rbb666 reopened this Dec 25, 2024
@Rbb666 Rbb666 merged commit 0932e31 into RT-Thread:master Dec 25, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants