Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mem] Remove useless code And Update mem documentation #8808

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

wdfk-prog
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

前两个CI报错可以不管 但是后面的CI报错需要处理 代码有问题

@wdfk-prog
Copy link
Contributor Author

前两个CI报错可以不管 但是后面的CI报错需要处理 代码有问题

看不明白有什么问题?没找到报错具体的文件和代码啊

@mysterywolf mysterywolf reopened this Apr 17, 2024
Comment on lines -62 to -64
#ifdef ARCH_CPU_64BIT
rt_uint32_t resv;
#endif /* ARCH_CPU_64BIT */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块为啥删除了?估计是这块导致的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resv 是reserve的意思,即保留这块内存空间。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ut 测试用例不过

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块为啥删除了?估计是这块导致的

这个是之前的实现保留的;为了在64bit上凑满8字节;
现在使用新的类型rt_ubase_t在64BIT上就是8字节了;所以已经没用可以删除了.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ut 测试用例不过

mem_tc里面自己也定义了一个同样的结构体;修改了结构体导致的;
CI为什么不会显示具体错误的代码行在什么地方?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为ut是真的在运行,运行死机了。不是静态编译错误。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为ut是真的在运行,运行死机了。不是静态编译错误。

但是ut的条件判断不正确应该是会输出内容到控制台的;CI无法获取显示吗?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有道理 这块需要改进一下

@mysterywolf mysterywolf merged commit d8dcc05 into RT-Thread:master Apr 19, 2024
78 of 83 checks passed
@wdfk-prog wdfk-prog deleted the mem branch April 21, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants