-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mem] Remove useless code And Update mem documentation #8808
Conversation
前两个CI报错可以不管 但是后面的CI报错需要处理 代码有问题 |
看不明白有什么问题?没找到报错具体的文件和代码啊 |
#ifdef ARCH_CPU_64BIT | ||
rt_uint32_t resv; | ||
#endif /* ARCH_CPU_64BIT */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块为啥删除了?估计是这块导致的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resv 是reserve的意思,即保留这块内存空间。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ut 测试用例不过
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块为啥删除了?估计是这块导致的
这个是之前的实现保留的;为了在64bit上凑满8字节;
现在使用新的类型rt_ubase_t
在64BIT上就是8字节了;所以已经没用可以删除了.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ut 测试用例不过
mem_tc里面自己也定义了一个同样的结构体;修改了结构体导致的;
CI为什么不会显示具体错误的代码行在什么地方?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为ut是真的在运行,运行死机了。不是静态编译错误。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为ut是真的在运行,运行死机了。不是静态编译错误。
但是ut的条件判断不正确应该是会输出内容到控制台的;CI无法获取显示吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有道理 这块需要改进一下
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up