[smart] fixup of lwp recycling and mm varea #8206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarvid
force-pushed
the
shell/fix-pr8141-rc
branch
2 times, most recently
from
1666d91 to
8f9c70b
Compare
BernardXiong
approved these changes
Oct 31, 2023
polarvid
force-pushed
the
shell/fix-pr8141-rc
branch
from
8f9c70b to
350a239
Compare
Co-authored-by: xqyjlj <[email protected]> Signed-off-by: shell <[email protected]>
feat: cleanup recycling routine of lwp. The tty is not recycled on exit() currenttly. This patch add a new layer of resource recycling including address space, fd tables, etc. Also, the pid is allocated from parent proc, so it's much reasonable to recycle the pid in parent process. So it's moved to waitpid() now. fixup: trap fixup in normal context Signed-off-by: Shell <[email protected]>
feat: moving varea pgmgr to anon. Page manager is only a internal structure of anonymous mapping currently. So it's moved to mm_anon.c now. This patch also includes a bug fix of extra cleanup of varea in page manager while doing varea_merge operations. feat: remove restriction on page install fixup: mm test case. Using the assertion uassert_true(!(lwp_ref_dec(lwp) - 1)) instead of uassert_true(!(lwp_ref_dec(lwp))) since the lwp_ref_dev returns the previous value of the lwp reference Signed-off-by: Shell <[email protected]>
polarvid
force-pushed
the
shell/fix-pr8141-rc
branch
from
350a239 to
e2530f8
Compare
BernardXiong
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
The previous implementation of lwp recycling is all done in
lwp_free(),which suspends the parent process for a long time in
wait(2)until all the resourcesis released, especially that
lwp_free()is running on a defunct thread witha extremely low priority.
If the parent process never wait for its children, all the resources is holding
until the parent process exits, which decreases the throughput of the system.
你的解决方案是什么 (what is your solution)
This patch includes:
mm_object.c&mm_anon.c在什么测试环境下测试通过 (what is the test environment)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up