清除部分编译告警和错误 #8171
Closed
清除部分编译告警和错误 #8171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guozhanxin
reviewed
Oct 27, 2023
| @@ -238,7 +238,7 @@ struct rt_sensor_data | |||
|
|
|||
| struct rt_sensor_ops | |||
| { | |||
| rt_size_t (*fetch_data)(struct rt_sensor_device *sensor, void *buf, rt_size_t len); | |||
| rt_ssize_t (*fetch_data)(struct rt_sensor_device *sensor, void *buf, rt_size_t len); | |||
There was a problem hiding this comment.
这个没在来回改，这个更改是正确的 rt_ssize_t
Guozhanxin
reviewed
Oct 27, 2023
| @@ -55,13 +55,13 @@ extern "C" { | |||
|
|
|||
| struct stat | |||
| { | |||
| struct rt_device *st_dev; | |||
| dev_t st_dev; | |||
Guozhanxin
reviewed
Oct 27, 2023
components/net/sal/src/sal_socket.c
Outdated
| @@ -1182,7 +1182,7 @@ int sal_ioctlsocket(int socket, long cmd, void *arg) | |||
| } | |||
|
|
|||
| case SIOCSIFNETMASK: | |||
| if (!strcmp(ifr->ifr_ifrn.ifrn_name, sock->netdev->name)) | |||
| if (!rt_strcmp(ifr->ifr_ifrn.ifrn_name, sock->netdev->name)) | |||
BernardXiong
reviewed
Nov 1, 2023
components/finsh/msh.c
Outdated
| @@ -798,7 +798,7 @@ static msh_cmd_opt_t *msh_get_cmd_opt(char *opt_str) | |||
| char *ptr; | |||
| int len; | |||
|
|
|||
| if ((ptr = strchr(opt_str, ' '))) | |||
| if ((ptr = strchr(opt_str, ' ')) != RT_NULL) | |||
There was a problem hiding this comment.
这些需要移出来，赋值语句不应该放在条件判断中。下面的896行也是类似的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
清除MDK5 armcc部分编译告警和错误
你的解决方案是什么 (what is your solution)
在什么测试环境下测试通过 (what is the test environment)
潘多拉开发板
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up