[Bug] double free issue

[SoftSec-Tech]

RT-Thread Version

1cc0fb8

Hardware Type/Architectures

stm32

Develop Toolchain

GCC

Describe the bug

1. There is double free issue in line 770 of https://github.com/RT-Thread/rt-thread/blob/master/components/finsh/msh.c.
2. This issue was detected by Static Analysis tool - StatiCode,
   
   As in the screenshot, in step 38, call closedir(dir) and free the memory; And then in step 39, call closeddir(dir) and free memory again., which caused double free issue.

Other additional context

No response

[ChinoUkaegbu]

Hi I'd like to work on this but I don't think there's a double free issue. It seems like the closedir(dir) on line 770 is freeing the variable defined in line 631 while the closedir(dir) on line 761 is freeing the variable defined in line 759. If that's the case then I believe one of the variables may need to be renamed.

[BernardXiong]

Hi I'd like to work on this but I don't think there's a double free issue. It seems like the closedir(dir) on line 770 is freeing the variable defined in line 631 while the closedir(dir) on line 761 is freeing the variable defined in line 759. If that's the case then I believe one of the variables may need to be renamed.

Yes, you are right.

[mysterywolf]

fixed in #9464