Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying ranges in clarifications file and add strict usage checking for them #110

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

ol-teuto
Copy link
Contributor

We had the problem, that clarifications would go quickly out of sync due to automatic dependency updates.

This adds the ability to specify semver ranges in the clarifications file, because usually licenses don't change. Exact versions are still supported, so this shouldn't be a breaking change.

To make sure we don't accidentally miss when a dependency updates and is now out of the specified semver range, this also adds a new option --clarificationsMatchAll (not too sure about the name, other ideas welcome) which causes an error if one or multiple clarifications weren't actually used. This is off by default to keep the current behaviour of not erroring.

Copy link
Owner

@RSeidelsohn RSeidelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your improvement. Actually, I still do not understand the tests which are mostly untouched since I took over (forked) the project - so this is a big construction site for me still. This is why also the clarifications files are still partly a question mark to me.
Hopefully, this will change in the future.
And if you are interested, I would be happy to add you to the repo maintainers! All help is more than welcome, and I really think your last two additions add a lot of value to the project.

@RSeidelsohn RSeidelsohn merged commit 59cc778 into RSeidelsohn:master Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants