Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only include necessary files in package #106

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ol-teuto
Copy link
Contributor

Fixes #89

Explicitly lists the files that should be included in the package, so the test files are excluded. This also makes the .npmignore file obsolete, so I deleted it.

Copy link

@reinerBa reinerBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md and License do not need to be defined in "files". They are included by default.

Copy link

@LahTeuto LahTeuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@emersion
Copy link

Looks good to me as well, gentle ping @RSeidelsohn :)

Copy link
Owner

@RSeidelsohn RSeidelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @ol-teuto , I am deeply sorry for the looooong time I took to finally see and check your great PR. Thank you so much for doing this - I still have to learn more about the package.json file, I guess.

@RSeidelsohn RSeidelsohn merged commit 501244d into RSeidelsohn:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why this library weights 127MB?
5 participants